Add Session and SSL hooks to test_hooks Au test. by ywkaras · Pull Request #4576 · apache/trafficserver

ywkaras · 2018-11-08T00:56:11Z

No description provided.

ywkaras · 2018-11-08T00:57:16Z

This PR is dependent on #4566 .

shinrich

Seems reasonable to have a test that does a nominal invocation of all the hooks it can. The TLS hooks are tested more extensively in the tls_hook* tests. We need to write something similar for the tls_session hooks.

ywkaras · 2018-11-12T22:08:18Z

Don't merge till underlying PRs are resolved.

ywkaras · 2018-11-30T19:51:50Z

What else @zwoop ? Cut down the tallest tree in the forest with a herring?

#4651

SolidWallOfCode · 2019-01-03T16:59:27Z

The precursor PRs for this are all merged, as far as I can tell. @zwoop is probably on vacation and we'll have to wait till next week or so to move forward.

ywkaras · 2019-01-03T20:14:46Z

@zwoop please keep your block on this, the test does not run consistently. I think it's showing a problem with the VCONN start/end hooks. Sometimes they are executed for non-TLS VCONNs, sometimes they aren't. But when they are executed, the VCONNs are incorrectly considered to be SSL VCONNs.

C$ goldtst -f test_hooks
Running Test test_hooks:... Passed

Generating Report: --------------
Total of 1 test
  Unknown: 0
  Exception: 0
  Failed: 0
  Warning: 0
  Skipped: 0
  Passed: 1
wkaras ~/REPOS/TS/tests
C$ goldtst -f test_hooks
Running Test test_hooks:... Passed

Generating Report: --------------
Total of 1 test
  Unknown: 0
  Exception: 0
  Failed: 0
  Warning: 0
  Skipped: 0
  Passed: 1
wkaras ~/REPOS/TS/tests
C$ goldtst -f test_hooks
Running Test test_hooks:..F Failed

Generating Report: --------------
 Test: test_hooks: Failed
    File: test_hooks.test.py
    Directory: /Users/wkaras/REPOS/TS/tests/gold_tests/pluginTest/test_hooks
   Starting Test test_hooks : No issues found - Passed
      Reason: Started!
   Process: server: Passed
     Setting up : Lamda - Passed
     Setting up : MakeDir - Passed
     Test : Checking that any test passes - Passed
        Reason: One or more tests passed
     
       Test : Checking that ReturnCode == None - Failed
          Reason: Returned Value 0 != None
       
     
       Test : Checking that ReturnCode == 0 - Passed
          Reason: Returned Value: 0 == 0
       
   Process: ts: Passed
     Setting up : MakeDir - Passed
     Setting up : Copy - Passed
     Setting up : CopyAs - Passed
     Setting up : CopyAs - Passed
     Setting up : CopyAs - Passed
     Setting up : CopyAs - Passed
     Setting up : CopyAs - Passed
     Setting up : CopyAs - Passed
     Setting up : CopyAs - Passed
     Setting up : CopyAs - Passed
     Setting up : CopyAs - Passed
     Setting up : CopyAs - Passed
     Setting up : Copy - Passed
     Setting up : MakeDir - Passed
     Setting up : Copy - Passed
     Setting up : MakeDir - Passed
     Setting up : Chown - Passed
     Setting up : MakeDir - Passed
     Setting up : MakeDir - Passed
     Setting up : MakeDir - Passed
     Setting up : Chown - Passed
     Setting up : MakeDir - Passed
     Setting up : Chown - Passed
     Setting up : Lamda - Passed
     Setting up : Lamda - Passed
     Setting up : CopyAs - Passed
     Setting up : CopyAs - Passed
     Setting up : Copy - Passed
     Setting up : RunCommand - Passed
     Test : Checking that ReturnCode == 0 - Passed
        Reason: Returned Value: 0 == 0
     file /Users/wkaras/REPOS/TS/tests/_sandbox/test_hooks/ts/log/diags.log : diags.log should not contain errors - Passed
        Reason: Contents of /Users/wkaras/REPOS/TS/tests/_sandbox/test_hooks/ts/log/diags.log excludes expression
     file /Users/wkaras/REPOS/TS/tests/_sandbox/test_hooks/ts/log/diags.log : diags.log should not contain errors - Passed
        Reason: Contents of /Users/wkaras/REPOS/TS/tests/_sandbox/test_hooks/ts/log/diags.log excludes expression
     Appending File /Users/wkaras/REPOS/TS/tests/_sandbox/test_hooks/ts/config/records.config : Writing config file records.config - Passed
        Reason: Success
     Appending File /Users/wkaras/REPOS/TS/tests/_sandbox/test_hooks/ts/config/ssl_multicert.config : Appended file /Users/wkaras/REPOS/TS/tests/_sandbox/test_hooks/ts/config/ssl_multicert.config - Passed
        Reason: Success
     Appending File /Users/wkaras/REPOS/TS/tests/_sandbox/test_hooks/ts/config/plugin.config : Appended file /Users/wkaras/REPOS/TS/tests/_sandbox/test_hooks/ts/config/plugin.config - Passed
        Reason: Success
     Appending File /Users/wkaras/REPOS/TS/tests/_sandbox/test_hooks/ts/config/remap.config : Appended file /Users/wkaras/REPOS/TS/tests/_sandbox/test_hooks/ts/config/remap.config - Passed
        Reason: Success
   Process: Default: Skipped
      Reason: Was not started
   Process: Default: Skipped
      Reason: Was not started
   Run: 0-tr: Passed
     Process: Default: Passed
       Test : Checking that ReturnCode == 0 - Passed
          Reason: Returned Value: 0 == 0
     Process: Default: Passed
       Test : Checking that ReturnCode == 0 - Passed
          Reason: Returned Value: 0 == 0
   Run: 1-tr: Passed
     Process: Default: Passed
       Test : Checking that ReturnCode == 0 - Passed
          Reason: Returned Value: 0 == 0
     Process: Default: Passed
       Test : Checking that ReturnCode == 0 - Passed
          Reason: Returned Value: 0 == 0
   Run: 2-tr: Failed
     file log.txt : Checking that log.txt matches log.gold - Failed
        Reason: File differences
         Gold File : /Users/wkaras/REPOS/TS/tests/gold_tests/pluginTest/test_hooks/log.gold
         Data File : /Users/wkaras/REPOS/TS/tests/_sandbox/test_hooks/log.txt
         + Global: event=TS_EVENT_VCONN_START
         + Global: ssl flag=1
         + Global: event=TS_EVENT_VCONN_CLOSE
         + Global: ssl flag=1
           Global: event=TS_EVENT_HTTP_SSN_START
           Global: event=TS_EVENT_HTTP_TXN_START
           Session: event=TS_EVENT_HTTP_TXN_START
           Global: event=TS_EVENT_HTTP_READ_REQUEST_HDR
           Session: event=TS_EVENT_HTTP_READ_REQUEST_HDR
           Transaction: event=TS_EVENT_HTTP_READ_REQUEST_HDR
           Global: event=TS_EVENT_HTTP_TXN_CLOSE
           Session: event=TS_EVENT_HTTP_TXN_CLOSE
           Transaction: event=TS_EVENT_HTTP_TXN_CLOSE
           Global: event=TS_EVENT_HTTP_SSN_CLOSE
           Session: event=TS_EVENT_HTTP_SSN_CLOSE
           Global: event=TS_EVENT_VCONN_START
           Global: ssl flag=1
           Global: event=TS_EVENT_SSL_SERVERNAME
           Global: ssl flag=1
           Global: event=TS_EVENT_SSL_CERT
           Global: ssl flag=1
           Global: event=TS_EVENT_HTTP_SSN_START
           Global: event=TS_EVENT_HTTP_TXN_START
           Session: event=TS_EVENT_HTTP_TXN_START
           Global: event=TS_EVENT_HTTP_READ_REQUEST_HDR
           Session: event=TS_EVENT_HTTP_READ_REQUEST_HDR
           Transaction: event=TS_EVENT_HTTP_READ_REQUEST_HDR
           Global: event=TS_EVENT_HTTP_TXN_CLOSE
           Session: event=TS_EVENT_HTTP_TXN_CLOSE
           Transaction: event=TS_EVENT_HTTP_TXN_CLOSE
           Global: event=TS_EVENT_HTTP_SSN_CLOSE
           Session: event=TS_EVENT_HTTP_SSN_CLOSE
           Global: event=TS_EVENT_VCONN_CLOSE
           Global: ssl flag=1
     Starting TestRun 2-tr : No Issues found - Passed
        Reason: Started!
     Process: Default: Passed
       Test : Checking that ReturnCode == 0 - Passed
          Reason: Returned Value: 0 == 0
     Process: Default: Passed
       Test : Checking that ReturnCode == 0 - Passed
          Reason: Returned Value: 0 == 0

Total of 1 test
  Unknown: 0
  Exception: 0
  Failed: 1
  Warning: 0
  Skipped: 0
  Passed: 0
wkaras ~/REPOS/TS/tests
C$ goldtst -f test_hooks
Running Test test_hooks:..F Failed

Generating Report: --------------
 Test: test_hooks: Failed
    File: test_hooks.test.py
    Directory: /Users/wkaras/REPOS/TS/tests/gold_tests/pluginTest/test_hooks
   Starting Test test_hooks : No issues found - Passed
      Reason: Started!
   Process: server: Passed
     Setting up : Lamda - Passed
     Setting up : MakeDir - Passed
     Test : Checking that any test passes - Passed
        Reason: One or more tests passed
     
       Test : Checking that ReturnCode == None - Failed
          Reason: Returned Value 0 != None
       
     
       Test : Checking that ReturnCode == 0 - Passed
          Reason: Returned Value: 0 == 0
       
   Process: ts: Passed
     Setting up : MakeDir - Passed
     Setting up : Copy - Passed
     Setting up : CopyAs - Passed
     Setting up : CopyAs - Passed
     Setting up : CopyAs - Passed
     Setting up : CopyAs - Passed
     Setting up : CopyAs - Passed
     Setting up : CopyAs - Passed
     Setting up : CopyAs - Passed
     Setting up : CopyAs - Passed
     Setting up : CopyAs - Passed
     Setting up : CopyAs - Passed
     Setting up : Copy - Passed
     Setting up : MakeDir - Passed
     Setting up : Copy - Passed
     Setting up : MakeDir - Passed
     Setting up : Chown - Passed
     Setting up : MakeDir - Passed
     Setting up : MakeDir - Passed
     Setting up : MakeDir - Passed
     Setting up : Chown - Passed
     Setting up : MakeDir - Passed
     Setting up : Chown - Passed
     Setting up : Lamda - Passed
     Setting up : Lamda - Passed
     Setting up : CopyAs - Passed
     Setting up : CopyAs - Passed
     Setting up : Copy - Passed
     Setting up : RunCommand - Passed
     Test : Checking that ReturnCode == 0 - Passed
        Reason: Returned Value: 0 == 0
     file /Users/wkaras/REPOS/TS/tests/_sandbox/test_hooks/ts/log/diags.log : diags.log should not contain errors - Passed
        Reason: Contents of /Users/wkaras/REPOS/TS/tests/_sandbox/test_hooks/ts/log/diags.log excludes expression
     file /Users/wkaras/REPOS/TS/tests/_sandbox/test_hooks/ts/log/diags.log : diags.log should not contain errors - Passed
        Reason: Contents of /Users/wkaras/REPOS/TS/tests/_sandbox/test_hooks/ts/log/diags.log excludes expression
     Appending File /Users/wkaras/REPOS/TS/tests/_sandbox/test_hooks/ts/config/records.config : Writing config file records.config - Passed
        Reason: Success
     Appending File /Users/wkaras/REPOS/TS/tests/_sandbox/test_hooks/ts/config/ssl_multicert.config : Appended file /Users/wkaras/REPOS/TS/tests/_sandbox/test_hooks/ts/config/ssl_multicert.config - Passed
        Reason: Success
     Appending File /Users/wkaras/REPOS/TS/tests/_sandbox/test_hooks/ts/config/plugin.config : Appended file /Users/wkaras/REPOS/TS/tests/_sandbox/test_hooks/ts/config/plugin.config - Passed
        Reason: Success
     Appending File /Users/wkaras/REPOS/TS/tests/_sandbox/test_hooks/ts/config/remap.config : Appended file /Users/wkaras/REPOS/TS/tests/_sandbox/test_hooks/ts/config/remap.config - Passed
        Reason: Success
   Process: Default: Skipped
      Reason: Was not started
   Process: Default: Skipped
      Reason: Was not started
   Run: 0-tr: Passed
     Process: Default: Passed
       Test : Checking that ReturnCode == 0 - Passed
          Reason: Returned Value: 0 == 0
     Process: Default: Passed
       Test : Checking that ReturnCode == 0 - Passed
          Reason: Returned Value: 0 == 0
   Run: 1-tr: Passed
     Process: Default: Passed
       Test : Checking that ReturnCode == 0 - Passed
          Reason: Returned Value: 0 == 0
     Process: Default: Passed
       Test : Checking that ReturnCode == 0 - Passed
          Reason: Returned Value: 0 == 0
   Run: 2-tr: Failed
     file log.txt : Checking that log.txt matches log.gold - Failed
        Reason: File differences
         Gold File : /Users/wkaras/REPOS/TS/tests/gold_tests/pluginTest/test_hooks/log.gold
         Data File : /Users/wkaras/REPOS/TS/tests/_sandbox/test_hooks/log.txt
         + Global: event=TS_EVENT_VCONN_START
         + Global: ssl flag=1
         + Global: event=TS_EVENT_VCONN_CLOSE
         + Global: ssl flag=1
           Global: event=TS_EVENT_HTTP_SSN_START
           Global: event=TS_EVENT_HTTP_TXN_START
           Session: event=TS_EVENT_HTTP_TXN_START
           Global: event=TS_EVENT_HTTP_READ_REQUEST_HDR
           Session: event=TS_EVENT_HTTP_READ_REQUEST_HDR
           Transaction: event=TS_EVENT_HTTP_READ_REQUEST_HDR
           Global: event=TS_EVENT_HTTP_TXN_CLOSE
           Session: event=TS_EVENT_HTTP_TXN_CLOSE
           Transaction: event=TS_EVENT_HTTP_TXN_CLOSE
           Global: event=TS_EVENT_HTTP_SSN_CLOSE
           Session: event=TS_EVENT_HTTP_SSN_CLOSE
           Global: event=TS_EVENT_VCONN_START
           Global: ssl flag=1
           Global: event=TS_EVENT_SSL_SERVERNAME
           Global: ssl flag=1
           Global: event=TS_EVENT_SSL_CERT
           Global: ssl flag=1
           Global: event=TS_EVENT_HTTP_SSN_START
           Global: event=TS_EVENT_HTTP_TXN_START
           Session: event=TS_EVENT_HTTP_TXN_START
           Global: event=TS_EVENT_HTTP_READ_REQUEST_HDR
           Session: event=TS_EVENT_HTTP_READ_REQUEST_HDR
           Transaction: event=TS_EVENT_HTTP_READ_REQUEST_HDR
           Global: event=TS_EVENT_HTTP_TXN_CLOSE
           Session: event=TS_EVENT_HTTP_TXN_CLOSE
           Transaction: event=TS_EVENT_HTTP_TXN_CLOSE
           Global: event=TS_EVENT_HTTP_SSN_CLOSE
           Session: event=TS_EVENT_HTTP_SSN_CLOSE
           Global: event=TS_EVENT_VCONN_CLOSE
           Global: ssl flag=1
     Starting TestRun 2-tr : No Issues found - Passed
        Reason: Started!
     Process: Default: Passed
       Test : Checking that ReturnCode == 0 - Passed
          Reason: Returned Value: 0 == 0
     Process: Default: Passed
       Test : Checking that ReturnCode == 0 - Passed
          Reason: Returned Value: 0 == 0

Total of 1 test
  Unknown: 0
  Exception: 0
  Failed: 1
  Warning: 0
  Skipped: 0
  Passed: 0
wkaras ~/REPOS/TS/tests
C$ goldtst -f test_hooks
Running Test test_hooks:... Passed

Generating Report: --------------
Total of 1 test
  Unknown: 0
  Exception: 0
  Failed: 0
  Warning: 0
  Skipped: 0
  Passed: 1
wkaras ~/REPOS/TS/tests
C$

fixed

ywkaras · 2019-01-05T00:27:20Z

OK @zwoop I think this is ready to be merged now.

ywkaras · 2019-01-08T01:17:32Z

changed per @shinrich 's requests

zwoop

Ship it.

bryancall assigned ywkaras Nov 8, 2018

bryancall added the Tests label Nov 8, 2018

bryancall added this to the 9.0.0 milestone Nov 8, 2018

ywkaras force-pushed the TestHooks branch 2 times, most recently from 73658bf to 149749c Compare November 10, 2018 02:37

zwoop previously requested changes Nov 11, 2018

View reviewed changes

Comment thread include/ts/apidefs.h.in Outdated

ywkaras force-pushed the TestHooks branch from 149749c to fbfbc96 Compare November 12, 2018 17:31

shinrich previously approved these changes Nov 12, 2018

View reviewed changes

ywkaras dismissed shinrich’s stale review via daabecd November 29, 2018 22:25

ywkaras force-pushed the TestHooks branch from fbfbc96 to daabecd Compare November 29, 2018 22:25

ywkaras mentioned this pull request Jan 2, 2019

Add more information about event data to 'hook add' API function documentation. #4749

Merged

ywkaras force-pushed the TestHooks branch from daabecd to b344f5c Compare January 3, 2019 20:10

ywkaras force-pushed the TestHooks branch from b344f5c to 1773d93 Compare January 5, 2019 00:02

shinrich reviewed Jan 7, 2019

View reviewed changes

Comment thread tests/gold_tests/pluginTest/test_hooks/test_hooks.test.py Outdated

shinrich reviewed Jan 7, 2019

View reviewed changes

Comment thread tests/gold_tests/pluginTest/test_hooks/test_hooks.test.py Outdated

Add Session and SSL hooks to test_hooks Au test.

2f39b73

ywkaras force-pushed the TestHooks branch from 1773d93 to 2f39b73 Compare January 8, 2019 01:12

zwoop approved these changes Jan 15, 2019

View reviewed changes

zwoop merged commit 97b3511 into apache:master Jan 15, 2019

bryancall changed the title ~~Add Session and SSL hooks to test_hooks Au test.~~ Add Session and SSL hooks to test_hooks Au test. Sep 28, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Session and SSL hooks to test_hooks Au test.#4576

Add Session and SSL hooks to test_hooks Au test.#4576
zwoop merged 1 commit intoapache:masterfrom
ywkaras:TestHooks

ywkaras commented Nov 8, 2018

Uh oh!

ywkaras commented Nov 8, 2018

Uh oh!

Uh oh!

shinrich left a comment

Uh oh!

ywkaras commented Nov 12, 2018

Uh oh!

ywkaras commented Nov 30, 2018 •

edited

Loading

Uh oh!

SolidWallOfCode commented Jan 3, 2019

Uh oh!

ywkaras commented Jan 3, 2019 •

edited

Loading

Uh oh!

ywkaras commented Jan 5, 2019

Uh oh!

Uh oh!

Uh oh!

ywkaras commented Jan 8, 2019

Uh oh!

zwoop left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

ywkaras commented Nov 8, 2018

Uh oh!

ywkaras commented Nov 8, 2018

Uh oh!

Uh oh!

shinrich left a comment

Choose a reason for hiding this comment

Uh oh!

ywkaras commented Nov 12, 2018

Uh oh!

ywkaras commented Nov 30, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SolidWallOfCode commented Jan 3, 2019

Uh oh!

ywkaras commented Jan 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ywkaras commented Jan 5, 2019

Uh oh!

Uh oh!

Uh oh!

ywkaras commented Jan 8, 2019

Uh oh!

zwoop left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ywkaras commented Nov 30, 2018 •

edited

Loading

ywkaras commented Jan 3, 2019 •

edited

Loading