Add more information about event data to 'hook add' API function documentation.#4749
Merged
Merged
Conversation
ywkaras
force-pushed
the
EdataMutexDoc
branch
3 times, most recently
from
a871a6c to
4093dcd
Compare
bryancall
reviewed
Jan 7, 2019
| TSHttpHookAdd(TS_VCONN_CLOSE_HOOK, gCont); | ||
|
|
||
| // TSHttpHookAdd(TS_SSL_SESSION_HOOK, gCont); -- Event is TS_EVENT_SSL_SESSION_NEW -- Event data is TSHttpSsn | ||
| // TSHttpHookAdd(TS_SSL_SERVER_VERIFY_HOOK, gCont); |
Contributor
There was a problem hiding this comment.
Is there a reason these are commented out? Why are the hooks not being called?
Contributor
Author
There was a problem hiding this comment.
They don't seem to be working.
Contributor
|
@ywkaras Can you please squash the commits. |
ywkaras
force-pushed
the
EdataMutexDoc
branch
from
9f8a4e7 to
4624da6
Compare
Member
|
@ywkaras - did you mean to drop all those test changes in your recent force push? |
Contributor
Author
|
@SolidWallOfCode they we're dropped, they were part of another PR that has been merged. |
SolidWallOfCode
approved these changes
Jan 22, 2019
bryancall
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is dependent on #4576 .