-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[docker] Update CI to Python 3.7 and Ubuntu 18 #10247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
leandron
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this @driazati - I have a set of patches lined up for the Ubuntu 20 migration, that we can plan for the near future.
In the meantime, a few comments below.
|
|
||
| wget -q -O - http://apt.llvm.org/llvm-snapshot.gpg.key|sudo apt-key add - | ||
| apt-get update && apt-get install -y llvm-4.0 llvm-9 llvm-8 llvm-7 clang-9 libclang-9-dev clang-8 libclang-8-dev clang-7 libclang-7-dev | ||
| apt-get install -y llvm-4.0 llvm-9 llvm-8 llvm-7 clang-9 libclang-9-dev clang-8 libclang-8-dev clang-7 libclang-7-dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a separate issue, but do we still need LLVM 4?
This updates the docker image build to use Python 3.7 and Ubuntu 18 as discussed in #9703. The update is mostly straightforward except that the `apt` boost isn't built with 3.7 so we must now build it from source.
leandron
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @driazati
|
Thanks for this @driazati, looking forward to these images 😸 |
Looks like we did need the redirect in (apache#10247), otherwise you get a blank redirect response and `tar` doesn't like that very much: ``` tar: This does not look like a tar archive gzip: stdin: unexpected end of file ```
This updates the docker image build to use Python 3.7 and Ubuntu 18 as discussed in apache#9703. The update is mostly straightforward except that the `apt` boost isn't built with 3.7 so we must now build it from source.
…pache#10343) Looks like we did need the redirect in (apache#10247), otherwise you get a blank redirect response and `tar` doesn't like that very much: ``` tar: This does not look like a tar archive gzip: stdin: unexpected end of file ```
This updates the docker image build to use Python 3.7 and Ubuntu 18 as discussed in #9703. The update is mostly straightforward except that the
aptboost isn't built with 3.7 so we must now build it from source.cc @leandron @areusch