[TIR][Schedule] Allow named block and buffer arguments in Schedule #11624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has previously been implemented for `Schedule.transform_layout` in apache#11296, extending to allow for block arguments in all `Schedule` methods. This change was only made for arguments that must be a `BlockRV`. For arguments that may be either a `BlockRV` or another type (e.g. `Schedule.get_child_blocks` accepts either `BlockRV` or `LoopRV`), this sugar is not implemented, to avoid ambiguity.
Similar to apache#11269, which added this functionality to `Schedule.transform_layout`.
vinx13
approved these changes
Jun 9, 2022
Kathryn-cat
pushed a commit
to Kathryn-cat/tvm
that referenced
this pull request
Jun 10, 2022
…pache#11624) * [Schedule] Allowed string argument as block arg This has previously been implemented for `Schedule.transform_layout` in apache#11296, extending to allow for block arguments in all `Schedule` methods. This change was only made for arguments that must be a `BlockRV`. For arguments that may be either a `BlockRV` or another type (e.g. `Schedule.get_child_blocks` accepts either `BlockRV` or `LoopRV`), this sugar is not implemented, to avoid ambiguity. * [Schedule] Allowed string argument to Schedule.reindex Similar to apache#11269, which added this functionality to `Schedule.transform_layout`. * CI test update
Lunderberg
added a commit
to Lunderberg/tvm
that referenced
this pull request
Aug 31, 2022
Previously, the argument needed to be an integer specifying the index into the read/write regions of a block. Now, the argument can be a string specifying the name of the buffer, or the Buffer object itself. This is a follow-up from apache#11624.
Lunderberg
added a commit
to Lunderberg/tvm
that referenced
this pull request
Aug 31, 2022
Previously, the argument needed to be an integer specifying the index into the read/write regions of a block. Now, the argument can be a string specifying the name of the buffer, or the Buffer object itself. This is a follow-up from apache#11624.
Hzfengsy
pushed a commit
that referenced
this pull request
Sep 1, 2022
) Previously, the argument needed to be an integer specifying the index into the read/write regions of a block. Now, the argument can be a string specifying the name of the buffer, or the Buffer object itself. This is a follow-up from #11624.
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
…che#12661) Previously, the argument needed to be an integer specifying the index into the read/write regions of a block. Now, the argument can be a string specifying the name of the buffer, or the Buffer object itself. This is a follow-up from apache#11624.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow-up to #11269, starting to add similar quality-of-life functionality to other methods in
Schedule. They can only be used when it is unambiguous to do so, and translate the string name into the underlying C++ type before calling the FFI.Schedule.reindex, with the same calling convention asSchedule.transform_layout.