Skip to content

[microTVM][ARM] Enable tests that were skipped unintentionally #12223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mehrdadh merged 2 commits into from
Aug 1, 2022
Merged

[microTVM][ARM] Enable tests that were skipped unintentionally #12223

mehrdadh merged 2 commits into from
Aug 1, 2022

Conversation

@mehrdadh
Copy link
Member

@mehrdadh mehrdadh commented Jul 28, 2022 •
edited
Loading

ARM schedule tests on corstone300 are skipped right now. Log from this link:
https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/main/3899/pipeline/383

2022-07-28T20:08:51.701Z] tests/python/relay/strategy/arm_cpu/test_max_pool.py::TestMaxPool1d::test_pool[max_pool1d-int32-pool.arm_cpu-shape0-pool_size0-strides0-0-1-NCW-True] SKIPPED (ARM embedded toolchain unavailable)

[2022-07-28T20:08:51.701Z] tests/python/relay/strategy/arm_cpu/test_max_pool.py::TestMaxPool1d::test_pool[max_pool1d-int32-pool.arm_cpu-shape1-3-1-0-1-NWC-False] SKIPPED (ARM embedded toolchain unavailable)

[2022-07-28T20:08:51.701Z] tests/python/relay/strategy/arm_cpu/test_max_pool.py::TestMaxPool1d::test_pool[max_pool1d-int32-pool.arm_cpu-shape2-3-2-0-1-NWC-False] SKIPPED (ARM embedded toolchain unavailable)

[2022-07-28T20:08:51.701Z] tests/python/relay/strategy/arm_cpu/test_max_pool.py::TestMaxPool2d::test_pool[max_pool2d-int32-pool.arm_cpu-shape0-pool_size0-strides0-0-1-NCHW-False] SKIPPED (ARM embedded toolchain unavailable)

The bug was introduced in #11313
https://github.com/apache/tvm/pull/11313/files#diff-cde5d8f752ab76b94a72445b106884ca096adb729312a8ed270a7e7c96d14aadR956

cc @Lunderberg @alanmacd @areusch @gromero

@github-actions github-actions bot requested review from Lunderberg and areusch July 28, 2022 22:01
@gromero
Copy link
Contributor

gromero commented Jul 28, 2022 •
edited
Loading

@mehrdadh Hi. Could you please give a bit more of context here? The tests were skipped when / by which commit? Is it fixing which bug exactly? Any CI error or log you can point out / share so I can take a look at the error fixed by this fix?

@github-actions github-actions bot requested a review from gromero July 28, 2022 22:27
@mehrdadh
Copy link
Member Author

mehrdadh commented Jul 28, 2022 •
edited
Loading

@gromero sorry for missing details. I changed the description

@mehrdadh mehrdadh force-pushed the micro/enable_arm_tests branch from e62f1ca to d083ddd Compare July 28, 2022 22:45
@mehrdadh mehrdadh mentioned this pull request Jul 29, 2022
Closed
Lunderberg
Lunderberg approved these changes Aug 1, 2022
View reviewed changes
Copy link
Contributor

@Lunderberg Lunderberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and thank you for the catch!

@mehrdadh mehrdadh merged commit e2d139a into apache:main Aug 1, 2022
@mehrdadh mehrdadh deleted the micro/enable_arm_tests branch August 1, 2022 20:10
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
@mehrdadh @xinetzone
[microTVM][ARM] Enable tests that were skipped unintentionally (apach…
426e1ea 
…e#12223)

* fix bug to enable tests

* fix import issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lunderberg Lunderberg Lunderberg approved these changes

@areusch areusch Awaiting requested review from areusch

@gromero gromero Awaiting requested review from gromero

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mehrdadh @gromero @Lunderberg