[CMSIS-NN] Pad fusion with QNN Conv2D #12353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebastianBoblest
approved these changes
Aug 10, 2022
asparkhi
force-pushed
the
conv2d_pad_fusion
branch
from
5b616fa to
0cf87a3
Compare
lhutton1
reviewed
Aug 11, 2022
Contributor
lhutton1
left a comment
lhutton1
left a comment
There was a problem hiding this comment.
Left a few comments / questions.. see what you think
lhutton1
reviewed
Aug 18, 2022
Contributor
lhutton1
left a comment
lhutton1
left a comment
There was a problem hiding this comment.
Thanks for the improvements @ashutosh-arm, looks great! I just had a couple more small comments
added 5 commits
August 22, 2022 14:47
Change-Id: I2fd834dd93e7afdcc454c38700448e3f4d5eb0f5
Change-Id: I6073ce46aa1687aa68b3dc83c848dc5ec7e6d0e0
Change-Id: If58a54bc61d88d899399e6ce0d74ce4e71e7da4c
Change-Id: I4e09cde765586a576e75b4a6f6fdd9419c1ebdae
Change-Id: I1e032295668e68849a365da0dde28234c66cc056
asparkhi
force-pushed
the
conv2d_pad_fusion
branch
from
9f054f1 to
b0b48b3
Compare
lhutton1
approved these changes
Aug 23, 2022
Contributor
lhutton1
left a comment
lhutton1
left a comment
There was a problem hiding this comment.
Thanks for the updates @ashutosh-arm, LGTM!
Contributor
|
Thanks @ashutosh-arm, @SebastianBoblest! |
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
Pass that fuses nn.pad and qnn.conv2d for CMSIS-NN target.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass that fuses nn.pad and qnn.conv2d for CMSIS-NN target.
cc @Mousius @areusch @grant-arm @lhutton1 @manupa-arm