[ci] Split the ci/scripts directory into ci/scripts/github and ci/scripts/jenkins #12941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
areusch
reviewed
Oct 5, 2022
ci/jenkins/macros.j2
Outdated
| script: """ | ||
| set -eux | ||
| . ci/scripts/retry.sh | ||
| . ci/scripts/jenkins/retry.sh |
Contributor
There was a problem hiding this comment.
shall we make the jenkins script dir a var?
| from pathlib import Path | ||
| from typing import Dict, Tuple, Any, Optional, List, Union | ||
|
|
||
| # Hackery to enable importing of utils from ci/scripts/jenkins |
Contributor
There was a problem hiding this comment.
i think at some point we were going to make this a Python package, right? is the idea that this hack bridges the gap til that happens?
Contributor
There was a problem hiding this comment.
Yes, I think that's needed until we create the proper package structure.
|
|
||
|
|
||
| REPO_ROOT = Path(__file__).resolve().parent.parent.parent | ||
| REPO_ROOT = Path(__file__).resolve().parent.parent.parent.parent |
Contributor
There was a problem hiding this comment.
could also
assert (REPO_ROOT / "Jenkinsfile").exists
for stability
tests/python/ci/test_ci.py
Outdated
| Test that reviewers are added from 'cc @someone' messages in PRs | ||
| """ | ||
| reviewers_script = REPO_ROOT / "ci" / "scripts" / "github_cc_reviewers.py" | ||
| reviewers_script = REPO_ROOT / "ci" / "scripts" / "github" / "github_cc_reviewers.py" |
Contributor
There was a problem hiding this comment.
do we think this pattern is common enough to make GITHUB_SCRIPT_ROOT and JENKINS_SCRIPT_ROOT?
Contributor
driazati
force-pushed
the
separate-scripts
branch
from
a4b0489 to
923dcb2
Compare
areusch
added
needs-triage
driazati
pushed a commit
that referenced
this pull request
Nov 14, 2022
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
…13368) This PR is a duplicate of apache#12940 and apache#12941. For some reason, I am unable to reopen apache#12940.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a copy of #12940 to get it running in CI. The original description is copied below:
This PR separates the files in the
ci/scriptsdirectory intoci/scripts/jenkinsandci/scripts/github. This is done because thegithubscripts should not be protected in the CI. #12604