-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[ci][tvmbot] Fix spelling error, metionable -> mentionable #13276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
Mousius
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a line below in this file:
auth = [AUTH_CHECKS["metionable_users"]]
Can you update there as well and add a test as this almost got broken 😿
@driazati ^^^
|
Thanks for catching that. Thinking about appropriate tests. |
changes are now tested due to #13276, no new tests are necessary
In AUTH_CHECKS, "mentionable_users" was "metionable_users". This pull request fixes this spelling error. As pointed out in review, `metionable` is also used on line 674 of github_tvmbot.py, update this to `mentionable`.
I think you've linked back to this PR @driazati, which one did you mean to refer to? |
Mousius
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Leaving it with you @driazati 😸
|
Ah thanks for catching, I meant to link #13368 |
In AUTH_CHECKS, "mentionable_users" was "metionable_users".
This pull request fixes this spelling error.