Skip to content

Conversation

@alanmacd
Copy link
Contributor

@alanmacd alanmacd commented Nov 9, 2022

Split standard_crt build step into separate script to not build standard_crt on hexagon.

@tvm-bot
Copy link
Collaborator

tvm-bot commented Nov 9, 2022

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

  • Built docs for commit 54473c1 can be found here.
  • No users to auto-tag found, no teams are specified in PR title See #10317 for details

Generated by tvm-bot

@alanmacd alanmacd changed the title Disable call to ci_setup() for hexagon Split standard_crt build step into separate script to not build standard_crt on hexagon Nov 10, 2022
@mehrdadh mehrdadh requested a review from driazati November 10, 2022 19:39
@mehrdadh mehrdadh marked this pull request as ready for review November 10, 2022 19:39
Copy link
Member

@mehrdadh mehrdadh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'll wait for @driazati to take a look

@driazati
Copy link
Member

driazati commented Nov 10, 2022

Code looks good to me, if it works I’m good with merging but #13335 does this along with some other cleanups. To test we’ll need to push the PR branch to apache/tvm to actually run the Jenkinsfile changes nvm this is already done!

@alanmacd
Copy link
Contributor Author

alanmacd commented Nov 10, 2022

@driazati I'm fine with using #13335 for this change since it has other changes too.

@driazati
Copy link
Member

Can we close this since #13335 is merged?

@alanmacd alanmacd closed this Nov 22, 2022
@alanmacd alanmacd deleted the test-ci-setup-change-hexagon branch January 26, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants