[ci] Split out C++ unittests #13335
[ci] Split out C++ unittests #13335
Conversation
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
ci/jenkins/Build.groovy.j2
Outdated
| ) | ||
| make(ci_hexagon, 'build', '-j2') | ||
| cmake_build(ci_hexagon, 'build', '-j2') | ||
| make_standalone_crt(ci_hexagon, 'build') |
There was a problem hiding this comment.
We would want to remove make_standalone_crt() here for the hexagon build.
cc: @mehrdadh
| // make_cpp_tests(ci_gpu, 'build') | ||
| // cpp_unittest(ci_gpu) |
There was a problem hiding this comment.
These aren't run at all right now and are currently broken, so this leaves them commented out. The previous code uploaded the same binaries for both gpu and gpu2 since there was a fixed reference to the build directory. This resolves the issue which causes this to fail but doesn't fix the build failure itself, which we should leave for a follow up
| @@ -0,0 +1,44 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
ah forgot to add calls to these in the relevant jobs after their C++ testing, fixed
| popd | ||
| fi | ||
|
|
||
| pushd "${BUILD_DIR}" |
There was a problem hiding this comment.
I'm not sure what happened here. shouldn't ctest also move to wherever crttest was built?
There was a problem hiding this comment.
The build stuff should all be moved into the corresponding build stage and downloaded in the relevant test step to actually be run, so this removes all the building and just runs ctest (the other stuff behind the flags is also moved to the other test script below)
|
@driazati can you push your branch to a TVM branch to test the jenkins changes? |
|
Certain GitHub forks are configured in Jenkins to be trusted (e.g. those for people on the oss team), so the extra step to push to apache/tvm isn't necessary. You can see the info here: https://ci.tlcpack.ai/job/tvm/indexing/events, when a job comes from an untrusted source it'll say something like |
This makes C++ unittests follow the normal flow of build -> upload artifacts -> download and run tests. To simplify the changes there is a new utility for interacting with S3.
mehrdadh
left a comment
mehrdadh
left a comment
There was a problem hiding this comment.
LGTM, thanks for working on this!!
The docs deploy is broken following #13335: https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/main/4754/pipeline This avoids downloading the whole docs directory (which is just used to host documentation previews for PRs) and just grabs the `docs.tgz` which is actually used to deploy the docs. Co-authored-by: driazati <driazati@users.noreply.github.com>
* [ci] Split out C++ unittests This makes C++ unittests follow the normal flow of build -> upload artifacts -> download and run tests. To simplify the changes there is a new utility for interacting with S3. * Comments Co-authored-by: driazati <driazati@users.noreply.github.com>
The docs deploy is broken following apache#13335: https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/main/4754/pipeline This avoids downloading the whole docs directory (which is just used to host documentation previews for PRs) and just grabs the `docs.tgz` which is actually used to deploy the docs. Co-authored-by: driazati <driazati@users.noreply.github.com>
4 participants
This makes C++ unittests follow the normal flow of build -> upload
artifacts -> download and run tests. To simplify the changes there is a
new utility for interacting with S3.