[Meta Schedule] Patch ICHECK for target_has_vnni to avoid seg fault
#13441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
junrushao
reviewed
Nov 19, 2022
Member
junrushao
left a comment
junrushao
left a comment
There was a problem hiding this comment.
Thanks for spotting the typo! In this particular case, given the typo is pretty simple (an extra *) and easy to spot but hard to test, we do not have to add a unittest for it.
zxybazh
approved these changes
Nov 21, 2022
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
…apache#13441) * patch to avoid seg fault with test * address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the ICHECK for
target_has_vnniwould seg fault if this function is not found and no debug info is given. However this patch doesn't fix #13425. Note that the test case added wouldn't fail as the function should already be imported somehow by other imports.cc: @zxybazh