Skip to content

[Meta Schedule] Patch ICHECK for target_has_vnni to avoid seg fault #13441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zxybazh merged 2 commits into from
Nov 22, 2022
Merged

[Meta Schedule] Patch ICHECK for target_has_vnni to avoid seg fault #13441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f19795d
patch to avoid seg fault with test
Nov 19, 2022
81ce3e3
address comments
Nov 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/meta_schedule/space_generator/space_generator.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ String GetRuleKindFromTarget(const Target& target) {
if (target->kind->name == "llvm") {
static const PackedFunc* f_check_vnni =
runtime::Registry::Get("tvm.topi.x86.utils.target_has_vnni");
ICHECK(*f_check_vnni != nullptr) << "The `target_has_vnni` func is not in tvm registry.";
ICHECK(f_check_vnni != nullptr) << "The `target_has_vnni` func is not in tvm registry.";
if (target->GetAttr<String>("mcpu") &&
(*f_check_vnni)(target->GetAttr<String>("mcpu").value())) {
return "vnni";
Expand Down
1 change: 0 additions & 1 deletion tests/python/unittest/test_meta_schedule_space_cpu_winograd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
from tvm.meta_schedule.testing.space_generation import (
check_sketches,
generate_design_space,
print_sketches,
)
from tvm.meta_schedule.testing.te_workload import create_te_workload
from tvm.script import tir as T
Expand Down