[DOCKER][ADRENO] we don't need microtvm being built for android cross… #13486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… compilation PR:apache#13073 makes microtvm built by default with x86 compilers. Cross compilation fails due to this.
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment. Generated by tvm-bot |
echuraev
approved these changes
Nov 25, 2022
Member
|
@srkreddy1238 @echuraev Is it possible to add this cross compilation case to TVM CI so we can catch issues like this in pre-commit? We could have it at least in the build stage, basically cross compile android on an x86 docker image. wdyt? |
Contributor
|
@mehrdadh I think it is a good idea. I'm not sure if the Adreno docker is running in the CI or not. Maybe @srkreddy1238 might know better than me. Probably, we could add this docker image to CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… compilation
PR:#13073 makes microtvm built by default with x86 compilers. Cross compilation fails due to this.