Skip to content

[microTVM] enable building microTVM components by default #13073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mehrdadh merged 10 commits into from
Nov 22, 2022
Merged

[microTVM] enable building microTVM components by default #13073

mehrdadh merged 10 commits into from
Nov 22, 2022

Conversation

@alanmacd
Copy link
Contributor

@alanmacd alanmacd commented Oct 14, 2022 •
edited
Loading

  • Enable building microTVM components by default in build except for Hexagon and iOS.
  • Disable USE_MICRO for CPU minimal pending addition change to include StandaloneCRT with CPU minimal unit tests.

@tvm-bot
Copy link
Collaborator

tvm-bot commented Oct 14, 2022 •
edited
Loading

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@areusch areusch added needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it and removed needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it labels Oct 19, 2022
@elvin-n
Copy link
Contributor

elvin-n commented Oct 24, 2022

@tvm-bot rerun

@mehrdadh mehrdadh self-assigned this Nov 8, 2022
@mehrdadh
Copy link
Member

mehrdadh commented Nov 8, 2022

Looks like there's only one issue withe hexagon build with crt_standalone. Great progress!

@mehrdadh mehrdadh mentioned this pull request Nov 8, 2022
Closed
@alanmacd alanmacd changed the title [microTVM] enable building microTVM components by default in build [microTVM] enable building microTVM components by default Nov 8, 2022
mehrdadh
mehrdadh reviewed Nov 21, 2022
View reviewed changes
driazati
driazati reviewed Nov 21, 2022
View reviewed changes
Copy link
Member

@driazati driazati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just noting something we discussed offline, but the CI failures in https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/PR-13073/13/pipeline/542/#step-1557-log-1949 are difficult to fix in this PR due to Jenkins issues, so we should disable them for the CPU: minimal build (which has the env var PLATFORM set to minimal) temporarily, then I can follow up with a fix to re-enable them

@mehrdadh mehrdadh mentioned this pull request Nov 22, 2022
Closed
@alanmacd alanmacd marked this pull request as ready for review November 22, 2022 02:18
mehrdadh
mehrdadh approved these changes Nov 22, 2022
View reviewed changes
Copy link
Member

@mehrdadh mehrdadh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mehrdadh mehrdadh merged commit e662970 into apache:main Nov 22, 2022
@alanmacd alanmacd deleted the micro-always-on branch November 22, 2022 18:39
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
@alanmacd @mehrdadh @xinetzone
[microTVM] enable building microTVM components by default (apache#13073)
93a4dd7 
* enable micro by default

* apply patch for ranlib fix

* exclude windows build from including cctools

* remove check for USE_MICRO to build crttest

* disable USE_MICRO for hexagon builds

* remove USE_MICRO conditional from TVM python package init

* remove USE_MICRO restrictions for hexagon build

* remove USE_MICRO conditional for MISRA-C test

* set USE_MICRO to ON in tvm_option, set USE_MICRO to OFF for now in CPU minimal build

Co-authored-by: Mehrdad Hessar <mhessar@octoml.ai>
srkreddy1238 added a commit to srkreddy1238/tvm that referenced this pull request Nov 25, 2022
@srkreddy1238
[DOCKER][ADRENO] we don't need microtvm being built for android cross…
40f42b0 
… compilation

PR:apache#13073 makes microtvm built by default
with x86 compilers. Cross compilation fails due to this.
@srkreddy1238 srkreddy1238 mentioned this pull request Nov 25, 2022
Merged
@srkreddy1238
Copy link
Contributor

srkreddy1238 commented Nov 25, 2022

Cross compilations fails my making microtvm default.

@supersat supersat mentioned this pull request Nov 25, 2022
Merged
@supersat supersat mentioned this pull request Nov 25, 2022
Closed
@echuraev
Copy link
Contributor

echuraev commented Nov 25, 2022

@alanmacd, @mehrdadh could you please clarify why we have enabled building microTVM by default?

masahi pushed a commit that referenced this pull request Nov 28, 2022
@srkreddy1238
[DOCKER][ADRENO] we don't need microtvm being built for android cross… (
b8d7cd7 
#13486)

[DOCKER][ADRENO] we don't need microtvm being built for android cross compilation

PR:#13073 makes microtvm built by default
with x86 compilers. Cross compilation fails due to this.
@areusch
Copy link
Contributor

areusch commented Nov 28, 2022

ah @srkreddy1238 @echuraev sorry for the breakage. just to document the intent here: assuming you already compile with USE_RPC ON, the actual net effect of successfully compiling with USE_MICRO ON is to add a minimal transport layer. I think these breakages are likely due to standalone_crt being built via a Make-based system rather than cmake.

let's revert this one for now, and we'll retry at a later time with a cmake-based standalone_crt build, which should properly pick up CXX from the config.cmake.

areusch added a commit that referenced this pull request Nov 28, 2022
@areusch
Revert "[microTVM] enable building microTVM components by default (#1…
5be8107 
…3073)"

This reverts commit e662970.
@areusch areusch mentioned this pull request Nov 28, 2022
Merged
areusch added a commit that referenced this pull request Nov 29, 2022
@areusch
Revert "[microTVM] enable building microTVM components by default (#1…
6fa966f 
…3073)"

This reverts commit e662970.
echuraev pushed a commit that referenced this pull request Nov 29, 2022
@areusch
Revert "[microTVM] enable building microTVM components by default" (#…
57de9e7 
…13503)

* Revert "[microTVM] enable building microTVM components by default (#13073)"

This reverts commit e662970.

* USE_MICRO ON for minimal and wasm to work around CI limitation.

* revert USE_MICRO for wasm, unrelated
@areusch areusch mentioned this pull request Nov 30, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@driazati driazati driazati left review comments

@mehrdadh mehrdadh mehrdadh approved these changes

Assignees

@mehrdadh mehrdadh

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@alanmacd @tvm-bot @elvin-n @mehrdadh @srkreddy1238 @echuraev @areusch @driazati