Skip to content

Conversation

@areusch
Copy link
Contributor

@areusch areusch commented Nov 28, 2022

Reverts #13073 due to breakage of cases not covered by the CI. The cross-compile use case is particularly problematic.

Fixes #13482

@alanmacd @mehrdadh

@tvm-bot
Copy link
Collaborator

tvm-bot commented Nov 28, 2022

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@areusch
Copy link
Contributor Author

areusch commented Nov 28, 2022

fixes #13482

Copy link

@shingjan shingjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@areusch areusch force-pushed the revert-13073-micro-always-on branch from 7970648 to 3e3dd32 Compare November 29, 2022 01:16
echuraev added a commit that referenced this pull request Nov 29, 2022
Flag `-DUSE_MICRO=OFF` was added to avoid this issue #13482. In #13503 these changes were reverted. 
Removed unnecessary compilation flag to avoid user confusing.
@echuraev echuraev merged commit 57de9e7 into main Nov 29, 2022
masahi pushed a commit that referenced this pull request Nov 29, 2022
Flag `-DUSE_MICRO=OFF` was added to avoid this issue #13482. In #13503 these changes were reverted. 
Removed unnecessary compilation flag to avoid user confusing.
@tqchen tqchen deleted the revert-13073-micro-always-on branch January 10, 2023 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI Problem] cross-compilations are broken

5 participants