Skip to content

[Fix][ONNX] Fix CumSum conversion when loading ONNX model #18137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yongwww merged 2 commits into from
Jul 13, 2025
Merged

[Fix][ONNX] Fix CumSum conversion when loading ONNX model #18137

yongwww merged 2 commits into from
Jul 13, 2025

Conversation

@ConvolutedDog
Copy link
Contributor

@ConvolutedDog ConvolutedDog commented Jul 12, 2025 •
edited
Loading

  • Fix the ONNX CumSum converter to properly handle reversed cumsum operations by:
    • Flip the input before cumsum if reverse=True
    • Flip the output back to maintain original dimension order
    • Add proper normalization of the output of relax.op.cumsum
    • Add reverse=True test case to verify reversed cumsum operation

Details: This fixes #18135. ONNX allows users to explicitly specify the direction of cumsum through reverse. When reverse=True, the corresponding pseudo code is: flip(cumsum(flip(x, dims=[axis]), axis=axis), dims=[axis]).

@ConvolutedDog
Copy link
Contributor Author

ConvolutedDog commented Jul 12, 2025

@mshr-h Request a review.

@yongwww yongwww merged commit a519517 into apache:main Jul 13, 2025
14 checks passed
ConvolutedDog added a commit to ConvolutedDog/tvm that referenced this pull request Jul 14, 2025
@ConvolutedDog
[Upstream] Collection of PRs megered to upstream
3180e57 
- apache#18145
- apache#18144
- apache#18143
- apache#18138
- apache#18137
ShiboXing pushed a commit to ShiboXing/tvm that referenced this pull request Aug 10, 2025
@ConvolutedDog @ShiboXing
[Fix][ONNX] Fix CumSum conversion when loading ONNX model (apache#18137)
2d67deb 
* Fix onnx cumsum

* Fix onnx cumsum
@ysh329 ysh329 mentioned this pull request Oct 24, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yongwww yongwww yongwww approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] Error converting operator CumSum when 'reverse=1': (ptr) is false: The struct_info is not populated, check if you have normalized the expr

2 participants

@ConvolutedDog @yongwww