-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[Relax] Add layout inference support for repeat operator #18579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @guan404ming, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Relax framework by implementing layout inference for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds layout inference support for the relax.repeat operator. The implementation correctly handles two cases: when an axis is specified, it preserves the layout and transforms the axis accordingly; when no axis is specified, it correctly infers a 1D layout for the flattened output. The changes are well-tested with new unit tests covering both scenarios. My review includes a minor suggestion to improve code conciseness in the C++ implementation.
| int64_t new_axis = -1; | ||
| for (size_t i = 0; i < new_axis_str.size(); ++i) { | ||
| if (new_axis_str.at(i) == '1') { | ||
| new_axis = i; | ||
| break; | ||
| } | ||
| } | ||
| ICHECK_GE(new_axis, 0) << "Failed to find transformed axis"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
14d3e78 to
1a8740b
Compare
tlopex
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks
How