Fix broadcast add and subtract gradient calculation #2465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tqchen
approved these changes
Jan 19, 2019
Member
|
Thanks, @reminisce this is now merged. Please request reviewers next time :) |
Contributor
Author
|
@tqchen Thanks, I will. |
Anthony-Mai
pushed a commit
to Anthony-Mai/tvm
that referenced
this pull request
Jan 21, 2019
Anthony-Mai
pushed a commit
to Anthony-Mai/tvm
that referenced
this pull request
Jan 28, 2019
Anthony-Mai
pushed a commit
to Anthony-Mai/tvm
that referenced
this pull request
Jan 28, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Feb 20, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Feb 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gradient calculation of operators
addandsubtractare not correct when broadcasting is used in the forward pass. Fix the gradient calculation by changingbroadcast_to_liketocollapse_sum_likein gradient functions of these two ops.Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers.