[BUG][ConvertLayout] Fixes AttributeError during ConvertLayout to NHWC #6419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leandron
reviewed
Sep 8, 2020
lhutton1
force-pushed
the
fix-convert-layout
branch
2 times, most recently
from
fe2213d to
e68ec69
Compare
Contributor
|
cc @JoeyTPChou to take a look as well as he encountered the same issue weeks ago. |
|
Thanks for the work! |
JoeyTPChou
approved these changes
Sep 8, 2020
Fixes an issue described in apache#6410. In order to retrieve the shape a tensor `checked_type` should be used. Change-Id: I991d194d9cc15ee20464ff2e239fd05c035000c8
lhutton1
force-pushed
the
fix-convert-layout
branch
from
e68ec69 to
6c829f4
Compare
Contributor
Author
|
Apologies, just realized I forgot to add a call from main in the tests. |
electriclilies
approved these changes
Sep 9, 2020
zhiics
approved these changes
Sep 9, 2020
Member
lhutton1
added a commit
to lhutton1/tvm
that referenced
this pull request
Sep 10, 2020
… to unpack This patch follows a previous bugfix in apache#6419. I made a very simple oversight for qnn.conv2d in that tinfos also contains qnn parameters. Therefore, we need to extract data_info and weight_info differently. Change-Id: Ib0ad01f427543371380d0bb604a77b5e0ec1103d
lhutton1
added a commit
to lhutton1/tvm
that referenced
this pull request
Sep 10, 2020
… to unpack This patch follows a previous bugfix in apache#6419. I made a very simple oversight for qnn.conv2d in that tinfos also contains qnn parameters. Therefore, we need to extract data_info and weight_info differently. Change-Id: Ib0ad01f427543371380d0bb604a77b5e0ec1103d
lhutton1
added a commit
to lhutton1/tvm
that referenced
this pull request
Sep 14, 2020
… to unpack This patch follows a previous bugfix in apache#6419. I made a very simple oversight for qnn.conv2d in that tinfos also contains qnn parameters. Therefore, we need to extract data_info and weight_info differently. Change-Id: Ib0ad01f427543371380d0bb604a77b5e0ec1103d
kevinthesun
pushed a commit
to kevinthesun/tvm
that referenced
this pull request
Sep 17, 2020
…WC (apache#6419) Fixes an issue described in apache#6410. In order to retrieve the shape a tensor `checked_type` should be used. Change-Id: I991d194d9cc15ee20464ff2e239fd05c035000c8
kevinthesun
pushed a commit
to kevinthesun/tvm
that referenced
this pull request
Sep 17, 2020
… to unpack (apache#6442) This patch follows a previous bugfix in apache#6419. I made a very simple oversight for qnn.conv2d in that tinfos also contains qnn parameters. Therefore, we need to extract data_info and weight_info differently. Change-Id: Ib0ad01f427543371380d0bb604a77b5e0ec1103d
kevinthesun
pushed a commit
to kevinthesun/tvm
that referenced
this pull request
Sep 18, 2020
…WC (apache#6419) Fixes an issue described in apache#6410. In order to retrieve the shape a tensor `checked_type` should be used. Change-Id: I991d194d9cc15ee20464ff2e239fd05c035000c8
kevinthesun
pushed a commit
to kevinthesun/tvm
that referenced
this pull request
Sep 18, 2020
… to unpack (apache#6442) This patch follows a previous bugfix in apache#6419. I made a very simple oversight for qnn.conv2d in that tinfos also contains qnn parameters. Therefore, we need to extract data_info and weight_info differently. Change-Id: Ib0ad01f427543371380d0bb604a77b5e0ec1103d
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 18, 2020
…WC (apache#6419) Fixes an issue described in apache#6410. In order to retrieve the shape a tensor `checked_type` should be used. Change-Id: I991d194d9cc15ee20464ff2e239fd05c035000c8
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 18, 2020
… to unpack (apache#6442) This patch follows a previous bugfix in apache#6419. I made a very simple oversight for qnn.conv2d in that tinfos also contains qnn parameters. Therefore, we need to extract data_info and weight_info differently. Change-Id: Ib0ad01f427543371380d0bb604a77b5e0ec1103d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue described in #6410. In order to retrieve the shape of a tensor
tinfosshould be used.cc @leandron @anijain2305