[Refactor][VM] Port memory_alloc to c++ #7369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

masahi merged 2 commits into apache:main from zhiics:refactor_memory_alloc

Jan 29, 2021

Member

zhiics commented Jan 28, 2021

This PR ports the memory manifest pass to C++. This would help reduce compilation time for large models.

@masahi @icemelon9 @anijain2305 @jroesch @mbrookhart @kevinthesun

Member

masahi commented Jan 29, 2021

Do we want to remove the python version?

Member Author

zhiics commented Jan 29, 2021

@masahi oops, I missed a commit. We should be able to remove it


          Port memory_alloc to c++

0a09cbc

masahi reviewed

View reviewed changes

src/relay/transforms/memory_alloc.cc Show resolved Hide resolved

masahi reviewed

View reviewed changes

src/relay/transforms/memory_alloc.cc Outdated Show resolved Hide resolved

masahi reviewed

View reviewed changes

src/relay/transforms/memory_alloc.cc Show resolved Hide resolved

masahi reviewed

View reviewed changes

src/relay/transforms/memory_alloc.cc Outdated Show resolved Hide resolved

masahi reviewed

View reviewed changes

src/relay/transforms/memory_alloc.cc Outdated Show resolved Hide resolved

masahi reviewed

View reviewed changes

src/relay/transforms/memory_alloc.cc Show resolved Hide resolved

Member

masahi commented Jan 29, 2021

@zhiics FYI compiling MaskRCNN with C++ ManifestAlloc generates the following warning that I didn't see in the python version. I don't think it matters, just to let you know if you have a clue.

[11:50:01] /home/masa/projects/dev/tvm/src/relay/transforms/let_list.h:54: letlist not used
[11:50:01] /home/masa/projects/dev/tvm/src/relay/transforms/let_list.h:54: letlist not used
[11:50:01] /home/masa/projects/dev/tvm/src/relay/transforms/let_list.h:54: letlist not used
[11:50:04] /home/masa/projects/dev/tvm/src/relay/transforms/let_list.h:54: letlist not used
[11:50:04] /home/masa/projects/dev/tvm/src/relay/transforms/let_list.h:54: letlist not used
[11:50:04] /home/masa/projects/dev/tvm/src/relay/transforms/let_list.h:54: letlist not used
[11:50:07] /home/masa/projects/dev/tvm/src/relay/transforms/let_list.h:54: letlist not used
[11:50:07] /home/masa/projects/dev/tvm/src/relay/transforms/let_list.h:54: letlist not used
[11:50:07] /home/masa/projects/dev/tvm/src/relay/transforms/let_list.h:54: letlist not used


          remove memory python pass

ff9691f

zhiics force-pushed the refactor_memory_alloc branch from 2e08f55 to ff9691f Compare

January 29, 2021 07:24

Member Author

zhiics commented Jan 29, 2021 •

edited

Loading

@masahi yeah, thanks for reminding. Python pass wouldn't have it because it uses the Python ScopeBuilder. I tried a bit to see why where a LetList was deconstructed but I am not quite sure.

masahi approved these changes

View reviewed changes

Member

masahi left a comment

Looks great, thanks!

masahi merged commit 44a071a into apache:main

Member

masahi commented Jan 29, 2021

thanks @zhiics

masahi mentioned this pull request

[VM] Minor refactor for C++ memory alloc #7413

Merged

alexwong pushed a commit to alexwong/tvm that referenced this pull request


          [Refactor][VM] Port memory_alloc to c++ (apache#7369)

33c3cf7

* Port memory_alloc to c++

* remove memory python pass

electriclilies pushed a commit to electriclilies/tvm that referenced this pull request


          [Refactor][VM] Port memory_alloc to c++ (apache#7369)

4547d8c

* Port memory_alloc to c++

* remove memory python pass

Lokiiiiii pushed a commit to Lokiiiiii/tvm that referenced this pull request


          [Refactor][VM] Port memory_alloc to c++ (apache#7369)

06b01a9

* Port memory_alloc to c++

* remove memory python pass

trevor-m pushed a commit to neo-ai/tvm that referenced this pull request


          [Refactor][VM] Port memory_alloc to c++ (apache#7369)

0fb8a85

* Port memory_alloc to c++

* remove memory python pass

zhiics deleted the refactor_memory_alloc branch

April 17, 2021 01:29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet