[VM] Minor refactor for C++ memory alloc #7413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiics
reviewed
Feb 6, 2021
zhiics
reviewed
Feb 6, 2021
masahi
force-pushed
the
vm-alloc-refactor
branch
2 times, most recently
from
f0c7bc8 to
3cce3ad
Compare
masahi
force-pushed
the
vm-alloc-refactor
branch
from
3cce3ad to
9877ddf
Compare
zhiics
approved these changes
Feb 6, 2021
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 11, 2021
* started moving things to header * directly call InvokeTVMOp * done all memory op * also refactor AllocTensor * declare Prod * remove cached func for Add, Multiply, Divide * lint fix * revert test change * remove tensor.h and declare Prod in pattern_utils.h
Lokiiiiii
pushed a commit
to Lokiiiiii/tvm
that referenced
this pull request
Mar 2, 2021
* started moving things to header * directly call InvokeTVMOp * done all memory op * also refactor AllocTensor * declare Prod * remove cached func for Add, Multiply, Divide * lint fix * revert test change * remove tensor.h and declare Prod in pattern_utils.h
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 2, 2021
* started moving things to header * directly call InvokeTVMOp * done all memory op * also refactor AllocTensor * declare Prod * remove cached func for Add, Multiply, Divide * lint fix * revert test change * remove tensor.h and declare Prod in pattern_utils.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some leftover items from #7369, to be cleaner and safer.
Instead of getting a pointer to packed func and call it indirectly, just declare C++ op function in a header and call it directly.
cc @zhiics @jroesch