[Relay][Bugfix] Fix off-by-one error in BiasAddRel, use new reporting #7467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masahi
pushed a commit
to masahi/tvm
that referenced
this pull request
Feb 22, 2021
…apache#7467) * Fix off-by-one in BiasAddRel, use new reporting * No need to mark xfail if the exception is caught * lint
Lokiiiiii
pushed a commit
to Lokiiiiii/tvm
that referenced
this pull request
Mar 2, 2021
…apache#7467) * Fix off-by-one in BiasAddRel, use new reporting * No need to mark xfail if the exception is caught * lint
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 2, 2021
…apache#7467) * Fix off-by-one in BiasAddRel, use new reporting * No need to mark xfail if the exception is caught * lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in issue #7466, I noticed an off-by-one error in the assertions for
BiasAddReland also saw an opportunity to use the new error reporting. Not a huge error, but it probably doesn't hurt to have more graceful error reporting where possible.Requesting review from the last couple of people to change that file: @kevinthesun @tkonolige