[Relay][bugfix][error reporting] BiasAddRel does not check for a negative index being out of bounds #7554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkonolige
approved these changes
Mar 1, 2021
Contributor
tkonolige
left a comment
tkonolige
left a comment
There was a problem hiding this comment.
Thank you @slyubomirsky
tqchen
approved these changes
Mar 3, 2021
Member
|
Thanks you @slyubomirsky @tkonolige ! |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
…tive index being out of bounds (apache#7554)
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 11, 2021
…tive index being out of bounds (apache#7554)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up to #7467 on
bias_add, I realized the type relation wasn't bounds checking on the negative side. It's not a serious error, but it's good to have an informative error message for such cases. (I happened to be looking at that type relation because I was trying to formalize it in an ILP solver 😛)Please review @tkonolige @junrushao1994