Skip to content

Fix compile time and runtime errors of EdgeTPURuntime #8133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
masahi merged 3 commits into from
Jun 11, 2021
Merged

Fix compile time and runtime errors of EdgeTPURuntime #8133

masahi merged 3 commits into from
Jun 11, 2021

Conversation

@akmaru
Copy link
Contributor

@akmaru akmaru commented May 25, 2021

Fixed the errors of EdgeTPURuntime

  • Fixed compile error by the omission include "edgetpu.h"
  • Fixed SEGV in EdgeTPURuntime destructor.
    • It occurs if with destruction by the order EdgeTPUContext -> tflite::Interpreter. It maybe due to implementation of iflite::Interpreter. So, fixed to destruct by the reverse order by using EdgeTPUContext destructor.

@masahi masahi merged commit 657af3a into apache:main Jun 11, 2021
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Jun 17, 2021
@akmaru
Fix compile time and runtime errors of EdgeTPURuntime (apache#8133)
ff7f22b 
* Fixed the destruction order tflite::Interpreter and EdgeTPUContext

* Fixed include omission

* Formatted
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Jun 17, 2021
@akmaru @trevor-m
Fix compile time and runtime errors of EdgeTPURuntime (apache#8133)
7d81086 
* Fixed the destruction order tflite::Interpreter and EdgeTPUContext

* Fixed include omission

* Formatted
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@masahi masahi masahi approved these changes

Assignees

@tmoreau89 tmoreau89

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@akmaru @masahi @tmoreau89