Skip to content

Fix compile time and runtime errors of EdgeTPURuntime #8133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
masahi merged 3 commits into from
Jun 11, 2021
Merged

Fix compile time and runtime errors of EdgeTPURuntime #8133

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b3df3dd
Fixed the destruction order tflite::Interpreter and EdgeTPUContext
akmaru May 25, 2021
86363d8
Fixed include omission
akmaru May 25, 2021
531168d
Formatted
akmaru Jun 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/runtime/contrib/edgetpu/edgetpu_runtime.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
#include <string>

#include "../tflite/tflite_runtime.h"
#include "edgetpu.h"

namespace tvm {
namespace runtime {
Expand All @@ -43,6 +44,14 @@ namespace runtime {
*/
class EdgeTPURuntime : public TFLiteRuntime {
public:
/*!
* \brief Destructor of EdgeTPURuntime.
*
* NOTE: tflite::Interpreter member should be destruct before the EdgeTpuContext member
* destruction. If the order is reverse, occurs SEGV in the destructor of tflite::Interpreter.
*/
~EdgeTPURuntime() { interpreter_.reset(); }

/*!
* \return The type key of the executor.
*/
Expand Down