Skip to content

Conversation

@mikepapadim
Copy link
Contributor

This is a fix for #8674.

It always displays junit reports when tests fail.

@areusch

@areusch
Copy link
Contributor

areusch commented Aug 16, 2021

thanks @mikepapadim , pushed to https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/ci-docker-staging/144/pipeline with some injected test failures to see how they look!

@areusch
Copy link
Contributor

areusch commented Aug 16, 2021

@mikepapadim
Copy link
Contributor Author

I will check again. An alternative seems to be moving the junit as the following post-stage action:

 post {
        always {
            junit "build/pytest-results/*.xml"
        }
    }

@areusch
Copy link
Contributor

areusch commented Aug 18, 2021

@mikepapadim I think this might still be busted. can you see if you can run it through a staging jenkins? here's what i am using to test your change

@areusch
Copy link
Contributor

areusch commented Sep 14, 2021

@mikepapadim any update here?

@mikepapadim
Copy link
Contributor Author

@mikepapadim any update here?

Need to give it a go through CI. I ll update accordingly.

@mikepapadim
Copy link
Contributor Author

Let's wait for the CI, but now with the post-action per stage, test results should always be registerd.

Copy link
Contributor

@areusch areusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @mikepapadim i think the Jenkinsfile looks good now, just some extra cruft in this one. I pushed to https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/ci-docker-staging/159/pipeline with some injected test failures.

can you remove the cruft and assuming that build looks good (test failures are reported) we can merge?

Apache TVM is a compiler stack for deep learning systems. It is designed to close the gap between the
productivity-focused deep learning frameworks, and the performance- and efficiency-focused hardware backends.
TVM works with deep learning frameworks to provide end to end compilation to different backends.
ASDADA
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are a couple of random changes to .md files in here, can you revert?

@mikepapadim
Copy link
Contributor Author

thanks @mikepapadim i think the Jenkinsfile looks good now, just some extra cruft in this one. I pushed to https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/ci-docker-staging/159/pipeline with some injected test failures.

can you remove the cruft and assuming that build looks good (test failures are reported) we can merge?

I will fix them. Thanks for reviewing.

Btw if we go forward with #9042 then we might want to wait for this one as it could potentially be much cleaner with a declarive pipeline.

@areusch
Copy link
Contributor

areusch commented Sep 22, 2021

@mikepapadim let's merge this first, then migrate to #9042 separately. it will be more helpful to get test flakiness data sooner rather than later.

@denise-k
Copy link
Contributor

denise-k commented Jan 6, 2022

@areusch @mikepapadim any update on this?

@driazati
Copy link
Member

driazati commented Jan 6, 2022

With something like #9823 this could also help this be cleaner (since the post could be defined just once)

@jroesch jroesch added the needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it label Jan 19, 2022
@areusch
Copy link
Contributor

areusch commented Mar 24, 2022

closing due to stale PR and I believe this is implemented now

@areusch areusch closed this Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it status: need review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants