-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[CI] Modify Jenkinfile to always display junit report, fix for #8674 #8757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
thanks @mikepapadim , pushed to https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/ci-docker-staging/144/pipeline with some injected test failures to see how they look! |
|
hmm https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/ci-docker-staging/144/tests don't see any tests |
|
I will check again. An alternative seems to be moving the junit as the following post-stage action: |
|
@mikepapadim I think this might still be busted. can you see if you can run it through a staging jenkins? here's what i am using to test your change |
|
@mikepapadim any update here? |
Need to give it a go through CI. I ll update accordingly. |
|
Let's wait for the CI, but now with the post-action per stage, test results should always be registerd. |
areusch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @mikepapadim i think the Jenkinsfile looks good now, just some extra cruft in this one. I pushed to https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/ci-docker-staging/159/pipeline with some injected test failures.
can you remove the cruft and assuming that build looks good (test failures are reported) we can merge?
| Apache TVM is a compiler stack for deep learning systems. It is designed to close the gap between the | ||
| productivity-focused deep learning frameworks, and the performance- and efficiency-focused hardware backends. | ||
| TVM works with deep learning frameworks to provide end to end compilation to different backends. | ||
| ASDADA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are a couple of random changes to .md files in here, can you revert?
I will fix them. Thanks for reviewing. Btw if we go forward with #9042 then we might want to wait for this one as it could potentially be much cleaner with a declarive pipeline. |
|
@mikepapadim let's merge this first, then migrate to #9042 separately. it will be more helpful to get test flakiness data sooner rather than later. |
|
@areusch @mikepapadim any update on this? |
|
With something like #9823 this could also help this be cleaner (since the |
|
closing due to stale PR and I believe this is implemented now |
This is a fix for #8674.
It always displays
junitreports when tests fail.@areusch