Skip to content

Conversation

@comaniac
Copy link
Contributor

@comaniac comaniac commented Jan 3, 2022

A simple refactoring for skipping nodes in Jenkins by introducing a node wrapper.

cc @areusch

@comaniac comaniac requested a review from a team as a code owner January 3, 2022 22:50
@areusch
Copy link
Contributor

areusch commented Mar 24, 2022

@comaniac apologies i just saw this. we were actually discussing this and had started moving in the direction of templating the Jenkinsfile. the benefit here is that we can write a tool like tests/scripts/ci.py which can reproduce the CI without needing to parse/evaluate the Jenkinsfile locally (i looked into this approach about a year ago and it seems pretty fraught, not many local tools to help here). if you're okay going the template approach, would you like to review #10740?

@comaniac
Copy link
Contributor Author

Sure no worries.

@comaniac comaniac closed this Mar 24, 2022
@comaniac comaniac deleted the refaactor_jenkins branch March 24, 2022 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants