[Hexagon] Add contrib tests for blocked conv2d and maxpool2d #8960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csullivan
requested review from
areusch,
comaniac,
jroesch,
junrushao,
merrymercy,
tqchen and
yzhliu
as code owners
Contributor
Author
tmoreau89
reviewed
Sep 8, 2021
tmoreau89
reviewed
Sep 8, 2021
tmoreau89
reviewed
Sep 8, 2021
tmoreau89
reviewed
Sep 8, 2021
Contributor
tmoreau89
left a comment
tmoreau89
left a comment
There was a problem hiding this comment.
Great PR, thank you @csullivan ! Left some comments and nits
tmoreau89
reviewed
Sep 8, 2021
adstraw
reviewed
Sep 9, 2021
| int(ceildiv(in_channel, in_factor)), | ||
| kernel, | ||
| kernel, | ||
| in_factor // in_second_factor, |
Contributor
|
The changes look good to me. I like the hoisting of the shape definitions up into the |
Contributor
Author
|
Thanks for the feedback @tmoreau89 @adstraw @Lunderberg, I've updated the commit. Please take a look when you have a chance. |
tmoreau89
approved these changes
Sep 10, 2021
Contributor
tmoreau89
left a comment
tmoreau89
left a comment
There was a problem hiding this comment.
Thank you @csullivan the PR looks excellent, LGTM!
Contributor
|
Thank you @adstraw @Lunderberg @csullivan the PR has been merged |
areusch
reviewed
Sep 15, 2021
| # Combination of padding required by conv2d operator and padding to evenly divisible | ||
| # number of blocks. Note that this padding should be inlined in the schedule so | ||
| # as to avoid input copying. | ||
| pad_h = (block_H - ((H + padding[1]) % block_H)) % block_H |
Contributor
There was a problem hiding this comment.
is the second % block_H necessary?
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
…8960) * Add hexagon contrib tests for blocked conv2d and maxpool2d * Restructure based on review comments
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
…8960) * Add hexagon contrib tests for blocked conv2d and maxpool2d * Restructure based on review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds llvm unit tests that demonstrate the scheduling of conv2d and maxpool2d using a packed layout wherein spatial and channel dimensions are split into blocks. These tests can serve as a base off which to develop lowering for hexagon.