bug(tests): (Symfony)`ApiTestCase::createClient()` boot kernel on each call

[Crovitche-1623]

API Platform version(s) affected: x.y.z
3.x

Description
I don't know if it's a bug or the expected behaviour.

When I do use the RecreateDatabaseTrait from theofidry/alicebundle, the database is recreated each time the kernel is booted.

However, if I want to use multiple client (using the ApiPlatform\Symfony\Bundle\Test\ApiTestCase::createClient) or if the kernel is already booted, this cause problem because the database is recreated as the kernel is always booted without check.

IMHO, an additional check should be added to check if the kernel is already booted like the KernelTestCase::getContainer() does ?

I can take care of the PR if my issue is relevant.

[soyuka]

Just use disableReboot:

core/src/Symfony/Bundle/Test/Client.php

Lines 196 to 205 in ad54075

	/**
	* Disables kernel reboot between requests.
	*
	* By default, the Client reboots the Kernel for each request. This method
	* allows to keep the same kernel across requests.
	*/
	public function disableReboot(): void
	{
	$this->kernelBrowser->disableReboot();
	}

[Crovitche-1623]

Thanks @soyuka but I believe that the disableReboot method is intended to not restart the client between 2 requests, but in my situation it's different because I'm using 2 different clients.

[Crovitche-1623]

FYI, the first client I'm using is the original from Symfony because API Platform does not transform the form payload of a request to $request->request by default (that's the intended behaviour as described here).

I'm using the original Symfony client to do a first request using submitForm and then the APIP one to call API routes.

[soyuka]

can you propose a patch? we can do the check imo

[Crovitche-1623]

Done, tell me if anything is missing 👍🏻

[Crovitche-1623]

I close as the PR has been merged. Thanks @soyuka