fix: boot kernel only if it's necessary in createClient() method
#6976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Crovitche-1623
commented
Feb 18, 2025
Crovitche-1623
commented
| Q | A |
|---|---|
| Branch? | main |
| Tickets | Fix #6971 |
| License | MIT |
| Doc PR |
Contributor
Author
|
I don't understand why codecov checks fail because I don't think it's necessary to add tests for the test 😅 |
Member
|
nice thanks, don't worry about codecov it does weird things. Shouldn't we target 4.0 as a bug fix though? |
Contributor
Author
|
@soyuka I wondered also if it was a bugfix, but I figured it would change the behavior (BC) of those who already use Alice, maybe ? |
Crovitche-1623
force-pushed
the
patch-create-client
branch
from
96b965e to
31bd67d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.