chore: remove unnecessary annotation#1791
Merged
Conversation
valfirst
approved these changes
Nov 3, 2022
|
|
||
| import static io.appium.java_client.internal.CapabilityHelpers.APPIUM_PREFIX; | ||
|
|
||
| @Accessors |
Contributor
There was a problem hiding this comment.
Is the appropriate import sill used?
Member
There was a problem hiding this comment.
Nope its unused, it should be removed.
mykola-mokhnach
approved these changes
Nov 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change list
The accessors annotation can be removed when it has no arguments.
Types of changes
What types of changes are you proposing/introducing to Java client?
Put an
xin the boxes that applyDetails
It seems like the annotation is used only when we'd like to set non-default options
https://github.com/projectlombok/lombok/blob/560ded50127b12bd8168f8ae2bada47253f15bc8/src/core/lombok/core/AnnotationValues.java#L570
(i have tested without this annotation)