Skip to content

chore: remove unnecessary annotation #1791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KazuCocoa merged 3 commits into from
Nov 3, 2022
Merged

chore: remove unnecessary annotation #1791

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
962ce0c
chore: remove unnecessary annotation
KazuCocoa Nov 3, 2022
fda902f
add copyright
KazuCocoa Nov 3, 2022
cba799b
remove unused import
KazuCocoa Nov 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions src/main/java/io/appium/java_client/remote/DirectConnect.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,23 @@
/*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* See the NOTICE file distributed with this work for additional
* information regarding copyright ownership.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package io.appium.java_client.remote;

import lombok.AccessLevel;
import lombok.Getter;
import lombok.experimental.Accessors;

import javax.annotation.Nullable;
import java.net.MalformedURLException;
Expand All @@ -13,7 +28,6 @@

import static io.appium.java_client.internal.CapabilityHelpers.APPIUM_PREFIX;

@Accessors
Copy link
Copy Markdown
Contributor

@mykola-mokhnach mykola-mokhnach Nov 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the appropriate import sill used?

Copy link
Copy Markdown
Member

@SrinivasanTarget SrinivasanTarget Nov 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope its unused, it should be removed.

public class DirectConnect {
private static final String DIRECT_CONNECT_PROTOCOL = "directConnectProtocol";
private static final String DIRECT_CONNECT_PATH = "directConnectPath";
Expand Down