refactor: Replace cglib with bytebuddy#1923
Merged
mykola-mokhnach merged 7 commits intoappium:masterfrom May 25, 2023
Merged
Conversation
mykola-mokhnach
requested review from
SrinivasanTarget,
saikrishna321 and
valfirst
as code owners
valfirst
approved these changes
May 25, 2023
Collaborator
|
Thank you for making this fix. Huge for my team to finally get to java 17. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change list
cglib has the compatibility issue with newer Java versions, which seems unsolvable. butebuddy is a decent drop-in and works properly in Java17. Also, we and selenium itself already use this lib for driver proxies creation.