Add tooltip to custom data input #750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ArmanNik
suggested changes
Jan 29, 2024
| <FormItem> | ||
| <Label | ||
| tooltip="Deliver supplementary data alongside the notification, which remains hidden from the user's view but can be accessed by your application." | ||
| >Custom data <span class="u-color-text-gray">(Optional)</span></Label> |
Contributor
There was a problem hiding this comment.
The Label component has an optionalText variable that we can use for the (Optional) text instead of using the span :)
Contributor
Author
There was a problem hiding this comment.
When I switched to using optionalText the spacing between the text seemed too big. That means we need to change the margin, right?
TorstenDittmann
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a tooltip to help developers understand what custom data is.
Test Plan
Related PRs and Issues
None
Have you read the Contributing Guidelines on issues?
Yes