Skip to content

Add tooltip to custom data input #750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TorstenDittmann merged 1 commit into from
Feb 1, 2024
Merged

Add tooltip to custom data input #750

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/routes/console/project-[project]/messaging/wizard/pushFormList.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,11 @@
</Modal>
</div>
<form class="form">
<Label>Custom data <span class="u-color-text-gray">(Optional)</span></Label>
<FormItem>
<Label
tooltip="Deliver supplementary data alongside the notification, which remains hidden from the user's view but can be accessed by your application."
>Custom data <span class="u-color-text-gray">(Optional)</span></Label>
Copy link
Contributor

@ArmanNik ArmanNik Jan 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Label component has an optionalText variable that we can use for the (Optional) text instead of using the span :)

Copy link
Contributor Author

@stnguyen90 stnguyen90 Jan 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I switched to using optionalText the spacing between the text seemed too big. That means we need to change the margin, right?

image

</FormItem>
<div class=" u-grid u-gap-8">
<ul class="form-list" style="--p-form-list-gap: 1rem">
{#each customData || [] as _, rowIndex}
Expand Down