Skip to content

Conversation

@yuetloo
Copy link
Contributor

@yuetloo yuetloo commented Jul 27, 2021

The fix for this involved the changes in use-wallet and the client error screen.

@linear
Copy link

linear bot commented Jul 27, 2021

DAO-90 CLK_TERM_RANDOMNESS_NOT_YET gets Thrown...

Some contract calls(only transactions) in order to succeed need term to be up to date. Because of this, protocol-dashboard initiates multiple calls for the transaction(1st one is heartbeat call) so that heartbeat gets called first and then, the original transaction. This produces a problem when the original transaction needs to call draft on the DisputeManager. If the term is outdated and we call draft (summon guardians), term gets updated successfully, but draft fails, this is because there needs to be some time to pass after updating the term (calling heartbeat), and before calling the draft.

So we should find a way to add some kind of setTimeout mechanism to run the draft 10-15 seconds after the heartbeat is done .

DONE

Instead of setTimeouts, I decided to just restrict clicking on summon guardians button if the needed Transition is not 0 and add some warning text that it's worth waiting 1-2 minutes before calling draft if the term was updated lately.

@yuetloo yuetloo merged commit 1010d69 into feature/DAO-43-multichain Jul 27, 2021
@yuetloo yuetloo deleted the DAO-90-unsupport-chain-error branch July 27, 2021 23:36
novaknole added a commit that referenced this pull request Sep 1, 2021
* DAO-92 upgrade use wallet to 0.9.0 (#1557)

* use use-wallet 0.9.0

* remove unnecessary dependency

* fix the CI error @toruslabs/fetch-node-details@2.7.0 for node version too old

* Re-order templates (#1558)

* detect network change

* use injected instead of provided connector, as provided connector is a hack to around web3.js overrides

* switch welcome page content base on network

* more reactive network changes

* fix error on missing networkType

* eth node and ipfs settings by network

* getAppLocator by network type

Co-authored-by: Rekard0 <5880388+Rekard0@users.noreply.github.com>

* fix open organization error and slow down due to too many open websockets (#1563)

* show unsupported network error (#1565)

* DAO-104 CI job error (#1566)

* temporary use --network-concurrency 1, to be removed once use-wallet 0.9.0 is published.

* Merge to DAO-43-multichain (#1568)

* connectors redesigned for multichain

* local storage key missing network type

* DAO-83 only show network settings on mainnet (#1569)

* only show network settings on mainnet

* refresh org on network change (#1570)

* Dao 120 websocket leakage (#1572)

* refactor and attempt to fix websocket leaks

* fix connection error on socket disconnect web3

* eslint fixed

* update aragon wrapper

Co-authored-by: yuetloo <contact@yuetloo.com>

* Feature/dao 81 multi localstorage (#1573)

* connectors redesigned for multichain

* eslint problems fixed

* multi localstorage

* update multi localstorage

* update aragon.js wrapper

* eslint fixed

* DAO-128 connection not open (#1574)

* fix load org error on network switch

* ipfs settings is network agnostic

* code review comment

* remove mainnet from network type

* DAO-143 Create DAO freeze (#1579)

fix bug that caused create dao to freeze

* show wrong network on connect button and refactoring (#1575)

* fix screen id typo and clear cache error because wrapper = null (#1580)

* show network only for mainnet (#1581)

* DAO-139: remove sentry (#1582)

* show network only for mainnet

* replace logging with sentry with console.log

* remove sentry

* add newline

* remove obsolete .env.enc file

* DAO-162: handle network change in the middle of create DAO flow (#1583)

* fix deployment error due to missing wallet

* redirect to home on network change

* fix lint error

* DAO-194: use networkName from use-wallet (#1586)

* use networkName from use-wallet

* remove neteworkType.js

* revert network type changes for notification service

* update comment

* fix undefined web3 error (#1588)

* Feature/dao migration (#1590)

* connectors redesigned for multichain

* eslint problems fixed

* add govern migration page

* fix lint error

* add address field and refactoring

* add govern migration script call

* add govern migration handler

* remove network type

* update yarn.lock

* eslint fixed

* eslint fixed

* eslint fixed

* eslint fixed

* fix nullish operator

* fixed eslint

* fixed eslint

Co-authored-by: yuetloo <contact@yuetloo.com>

* add mumbai

* Feature/migration (#1592)

* add mumbai

* migration + multichain

* eslint fixed

* eslint fixed

* Fix/matic symbol on create (#1593)

* add mumbai

* fix matic symbol

* eslint fixed

* Feature/dao 233 hide discover apps (#1596)

* add mumbai

* add discover app check

* eslint fixed

* fix missing dependency in hook

* Feature/dao 235 copy missing (#1597)

* add mumbai

* fix network name on copy missing

* Feature/dao 230 remove templates (#1598)

* add mumbai

* add template removal for unavailable templates

* eslint fixed'

* Feature/update aragonui (#1599)

* add mumbai

* update aragon ui

* Feature/ DAO-222 (#1600)

* page ui updates

* update ui order

* add transaction pannel

* clean up

* fix lint

* add descripting to transaction

* remove unneccessary dep

Co-authored-by: Giorgi Lagidze <glagh14@freeuni.edu.ge>

* DAO-238 polygon no connection issue (#1601)

* fix no connection issue and eslint warning

* remove unneccessary comment

Co-authored-by: Giorgi Lagidze <glagh14@freeuni.edu.ge>

* Fix/govern migration check (#1602)

* add mumbai

* govern migration restriction

* fix eslint

* date restriction for migration

* eslint fixed

* DAO-239 initialize wrapper with Client network information (#1603)

* pass network to init wrapper

* from network to type + use wallet update

Co-authored-by: Giorgi Lagidze <glagh14@freeuni.edu.ge>

* update wrapper and multichain

* add ens registry for matic

* change matic socket

* matic node change

* enable migration on mainnet as well

* DAO-245 reset connection status on network switch (#1604)

* cleanup code

* reset isListening status on network switch

Co-authored-by: Rekard0 <5880388+Rekard0@users.noreply.github.com>
Co-authored-by: Giorgi Lagidze <glagh14@freeuni.edu.ge>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants