DAO-202: fix undefined web3 error #1588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DAO-202 DAO search broken
DAO search have 2 problems 1 - If I write the DAO name and hit enter, form is not submitted.. i need to go and manually click the search DAO btn 2 - DAO search should be case insensitive |
novaknole
added a commit
that referenced
this pull request
Sep 1, 2021
* DAO-92 upgrade use wallet to 0.9.0 (#1557) * use use-wallet 0.9.0 * remove unnecessary dependency * fix the CI error @toruslabs/fetch-node-details@2.7.0 for node version too old * Re-order templates (#1558) * detect network change * use injected instead of provided connector, as provided connector is a hack to around web3.js overrides * switch welcome page content base on network * more reactive network changes * fix error on missing networkType * eth node and ipfs settings by network * getAppLocator by network type Co-authored-by: Rekard0 <5880388+Rekard0@users.noreply.github.com> * fix open organization error and slow down due to too many open websockets (#1563) * show unsupported network error (#1565) * DAO-104 CI job error (#1566) * temporary use --network-concurrency 1, to be removed once use-wallet 0.9.0 is published. * Merge to DAO-43-multichain (#1568) * connectors redesigned for multichain * local storage key missing network type * DAO-83 only show network settings on mainnet (#1569) * only show network settings on mainnet * refresh org on network change (#1570) * Dao 120 websocket leakage (#1572) * refactor and attempt to fix websocket leaks * fix connection error on socket disconnect web3 * eslint fixed * update aragon wrapper Co-authored-by: yuetloo <contact@yuetloo.com> * Feature/dao 81 multi localstorage (#1573) * connectors redesigned for multichain * eslint problems fixed * multi localstorage * update multi localstorage * update aragon.js wrapper * eslint fixed * DAO-128 connection not open (#1574) * fix load org error on network switch * ipfs settings is network agnostic * code review comment * remove mainnet from network type * DAO-143 Create DAO freeze (#1579) fix bug that caused create dao to freeze * show wrong network on connect button and refactoring (#1575) * fix screen id typo and clear cache error because wrapper = null (#1580) * show network only for mainnet (#1581) * DAO-139: remove sentry (#1582) * show network only for mainnet * replace logging with sentry with console.log * remove sentry * add newline * remove obsolete .env.enc file * DAO-162: handle network change in the middle of create DAO flow (#1583) * fix deployment error due to missing wallet * redirect to home on network change * fix lint error * DAO-194: use networkName from use-wallet (#1586) * use networkName from use-wallet * remove neteworkType.js * revert network type changes for notification service * update comment * fix undefined web3 error (#1588) * Feature/dao migration (#1590) * connectors redesigned for multichain * eslint problems fixed * add govern migration page * fix lint error * add address field and refactoring * add govern migration script call * add govern migration handler * remove network type * update yarn.lock * eslint fixed * eslint fixed * eslint fixed * eslint fixed * fix nullish operator * fixed eslint * fixed eslint Co-authored-by: yuetloo <contact@yuetloo.com> * add mumbai * Feature/migration (#1592) * add mumbai * migration + multichain * eslint fixed * eslint fixed * Fix/matic symbol on create (#1593) * add mumbai * fix matic symbol * eslint fixed * Feature/dao 233 hide discover apps (#1596) * add mumbai * add discover app check * eslint fixed * fix missing dependency in hook * Feature/dao 235 copy missing (#1597) * add mumbai * fix network name on copy missing * Feature/dao 230 remove templates (#1598) * add mumbai * add template removal for unavailable templates * eslint fixed' * Feature/update aragonui (#1599) * add mumbai * update aragon ui * Feature/ DAO-222 (#1600) * page ui updates * update ui order * add transaction pannel * clean up * fix lint * add descripting to transaction * remove unneccessary dep Co-authored-by: Giorgi Lagidze <glagh14@freeuni.edu.ge> * DAO-238 polygon no connection issue (#1601) * fix no connection issue and eslint warning * remove unneccessary comment Co-authored-by: Giorgi Lagidze <glagh14@freeuni.edu.ge> * Fix/govern migration check (#1602) * add mumbai * govern migration restriction * fix eslint * date restriction for migration * eslint fixed * DAO-239 initialize wrapper with Client network information (#1603) * pass network to init wrapper * from network to type + use wallet update Co-authored-by: Giorgi Lagidze <glagh14@freeuni.edu.ge> * update wrapper and multichain * add ens registry for matic * change matic socket * matic node change * enable migration on mainnet as well * DAO-245 reset connection status on network switch (#1604) * cleanup code * reset isListening status on network switch Co-authored-by: Rekard0 <5880388+Rekard0@users.noreply.github.com> Co-authored-by: Giorgi Lagidze <glagh14@freeuni.edu.ge>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@novaknole , without the fix the gas estimation below would silently not work (no estimation), but, create dao still work. I'm debating if we should keep the gas estimation as the gas estimate may be too high now because of EIP1559.
https://github.com/aragon/client/blob/master/src/onboarding/Create/Create.js#L432-L434
Initially noticed this bug because the following line in ActivityContext logging error in console log.. from testing the govern dao migration...
https://github.com/aragon/client/blob/master/src/contexts/ActivityContext.js#L96