This repository was archived by the owner on Dec 18, 2018. It is now read-only.
Flush chunked writes before the entire response completes#599
Merged
Conversation
Member
Author
There was a problem hiding this comment.
@davidfowl Should I even be looking at $DNX_PACKAGES anymore? Should I just do like you did in aspnet/dnx@a440f9a and get rid of the GetHome method?
var profileDirectory = Environment.GetEnvironmentVariable("USERPROFILE");
if (string.IsNullOrEmpty(profileDirectory))
{
profileDirectory = Environment.GetEnvironmentVariable("HOME");
}
return Path.Combine(profileDirectory, ".nuget", "packages");
Ensure chunked writes force an "immediate" write by removing the now unused immediate parameter from ISocketOutput.Write
- Simply call SocketOutput.WriteAsync(_emptyData) to force headers to be flushed
79c528a to
a4b8b01
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #598