Skip to content
This repository was archived by the owner on Dec 18, 2018. It is now read-only.

Flush chunked writes before the entire response completes#599

Merged
halter73 merged 3 commits into
devfrom
shalter/always-immediate
Jan 27, 2016
Merged

Flush chunked writes before the entire response completes#599
halter73 merged 3 commits into
devfrom
shalter/always-immediate

Conversation

@halter73
Copy link
Copy Markdown
Member

Addresses #598

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidfowl Should I even be looking at $DNX_PACKAGES anymore? Should I just do like you did in aspnet/dnx@a440f9a and get rid of the GetHome method?

         var profileDirectory = Environment.GetEnvironmentVariable("USERPROFILE");
         if (string.IsNullOrEmpty(profileDirectory))
         {
              profileDirectory = Environment.GetEnvironmentVariable("HOME");
         }

         return Path.Combine(profileDirectory, ".nuget", "packages");

Ensure chunked writes force an "immediate" write by removing the now
unused immediate parameter from ISocketOutput.Write
- Simply call SocketOutput.WriteAsync(_emptyData) to force headers to be flushed
@halter73 halter73 force-pushed the shalter/always-immediate branch from 79c528a to a4b8b01 Compare January 25, 2016 19:11
@halter73 halter73 merged commit a4b8b01 into dev Jan 27, 2016
@halter73 halter73 deleted the shalter/always-immediate branch March 3, 2016 20:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants