This repository was archived by the owner on Dec 18, 2018. It is now read-only.
Combined fixes #567 and #599#603
Merged
Merged
Conversation
- Changed MockLibuv to never fall back to real libuv methods. - Fixed EngineTests.ConnectionCanReadAndWrite
…diate' into combined-fixes
Contributor
Author
|
Don't know about Travis failure; doesn't seem to be a new test that would do that |
Member
There was a problem hiding this comment.
This duplicate class should be removed.
benaadams
force-pushed
the
combined-fixes
branch
2 times, most recently
from
c4a1ec8 to
37be253
Compare
benaadams
force-pushed
the
combined-fixes
branch
from
37be253 to
00b8a13
Compare
Contributor
Author
|
Raised bug for Travis fail https://github.com/dotnet/corefx/issues/5694 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combines fixes in #567 and #599
Merge and rename clash resolved
Should build!!