This repository was archived by the owner on Dec 18, 2018. It is now read-only.
Make the CI build work#633
Closed
benaadams wants to merge 4 commits into
Closed
Conversation
Resolve compile warnings
benaadams
force-pushed
the
compile-warnings
branch
2 times, most recently
from
a784ba0 to
8e489cc
Compare
Contributor
Author
benaadams
force-pushed
the
compile-warnings
branch
from
8e489cc to
6b66b56
Compare
benaadams
force-pushed
the
compile-warnings
branch
from
6b66b56 to
7c30708
Compare
benaadams
force-pushed
the
compile-warnings
branch
from
15525af to
5a9f6cb
Compare
Contributor
Author
|
Crazy town! Lights are green! --> #635 |
Contributor
Member
|
I'm fairly certain the CI hangs are fixed by this commit. That's why I removed the same FrameworkSkipConditions in #623. The commit message should explain why the fix makes the second call to I think this is a more appropriate than setting the |
Contributor
Author
|
Is obviously better to have the cause dealt with rather than just the symptom :) Might be worth still adding the the |
Member
|
I think the |
Contributor
Author
|
Want to add it to #623? Will close this and the other one. |
Member
|
Will do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve compile warnings
Always shutdown