New baselines for HtmlBlockTest#2609
Conversation
| Equals;[=]; | ||
| MarkupTextLiteral - [14..15) - FullWidth: 1 - Gen<None> - SpanEditHandler;Accepts:Any | ||
| DoubleQuote;["]; | ||
| GenericBlock - [15..16) - FullWidth: 1 |
There was a problem hiding this comment.
I case you are wondering, this is to address @NTaylorMullen's comment in earlier PR (What's the difference between HtmlBlock and HtmlMarkupBlock?). GenericBlock is basically a wrapper when we need some parent block. It doesn't have a syntactic significance.
There was a problem hiding this comment.
Yes, that's the word
| SyntaxKind.ForwardSlash;[/]; | ||
| SyntaxKind.Text;[text]; | ||
| SyntaxKind.CloseAngle;[>]; | ||
| MarkupBlock - [0..30) - FullWidth: 30 - [<text>Foo Bar <foo> Baz</text>] |
| Equals;[=]; | ||
| MarkupTextLiteral - [14..15) - FullWidth: 1 - Gen<None> - SpanEditHandler;Accepts:Any | ||
| DoubleQuote;["]; | ||
| GenericBlock - [15..16) - FullWidth: 1 |
| Tag block - Gen<None> - 1 - (4:1,0) | ||
| Markup span - Gen<Markup> - [<] - SpanEditHandler;Accepts:Any - (4:1,0) - Tokens:1 | ||
| SyntaxKind.OpenAngle;[<]; | ||
| RazorDocument - [0..5) - FullWidth: 5 - [@{LF<] |
There was a problem hiding this comment.
Interesting, so only the first node in every file spits out the corresponding content? Hmmm
There was a problem hiding this comment.
Yes. It spits out the entire content of the tree aka the input
There was a problem hiding this comment.
Might be valuable to spit out content of each tag block
| Bang;[!]; | ||
| DoubleHyphen;[--]; | ||
| MarkupTextLiteral - [12..62) - FullWidth: 50 - Gen<Markup> - SpanEditHandler;Accepts:Whitespace | ||
| Whitespace;[ ]; |
There was a problem hiding this comment.
Might be easier to read if you swap the order of these and add some space
[ ]; Whitespace;
[Hello,]; Text
[ ]; Whitespace;
[I]; Text;
There was a problem hiding this comment.
I thought I'll keep the same ordering as before. I guess it might help to display the content of all *Literal nodes right next to it? Would that be helpful?
| SyntaxKind.Text;[foo]; | ||
| SyntaxKind.Whitespace;[ ]; | ||
| SyntaxKind.Text;[bar]; | ||
| MarkupBlock - [0..9) - FullWidth: 9 - [@:foo bar] |
There was a problem hiding this comment.
Eventually we'll want to represent @: as its own node type to have a better understanding of the syntax tree. Something like SingleLineMarkupBlock
|
@rynowak I'm merging this now because of git related reasons. I'll address your feedback if any in a later PR. |
3 participants
Most of these tests call
MarkupParser.ParseBlock()instead ofMarkupParser.ParseDocument(). So these test a different code path in the HtmlParser. Basically it tests the html inside a csharp block.