Skip to content
This repository was archived by the owner on Dec 19, 2018. It is now read-only.

New baselines for HtmlToCodeSwitchTest#2610

Merged
ajaybhargavb merged 1 commit into
feature/razor-parserfrom
ajbaaska/htmltocodeswitch
Sep 26, 2018
Merged

New baselines for HtmlToCodeSwitchTest#2610
ajaybhargavb merged 1 commit into
feature/razor-parserfrom
ajbaaska/htmltocodeswitch

Conversation

@ajaybhargavb
Copy link
Copy Markdown
Contributor

Mostly testing the same code paths as the previous PRs. No need to review super hard.

SyntaxKind.ForwardSlash;[/];
SyntaxKind.Text;[foo];
SyntaxKind.CloseAngle;[>];
RazorDocument - [0..19)::19 - [<foo>@@@@@bar</foo>]
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you notice, some tests have a RazorDocument wrapper and some don't. This means this test calls ParseDocumentTest and the others call ParseBlockTest on the input.

Equals;[=];
MarkupTextLiteral - [8..9)::1 - ["] - Gen<None> - SpanEditHandler;Accepts:Any
DoubleQuote;["];
GenericBlock - [9..36)::27
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe informational for me - what is GenericBlock?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I explained it in the previous PR. #2609 (comment). Pasting it below,

ajaybhargavb 18 hours ago Member

In case you are wondering, this is to address @NTaylorMullen's comment in earlier PR (What's the difference between HtmlBlock and HtmlMarkupBlock?). GenericBlock is basically a wrapper when we need some parent block. It doesn't have a syntactic significance.

NTaylorMullen 18 hours ago Member

Container?

ajaybhargavb 18 hours ago Member

Yes, that's the word

@rynowak
Copy link
Copy Markdown
Member

rynowak commented Sep 26, 2018

:shipit: - I did a quick skim of this, seemed right.

@ajaybhargavb ajaybhargavb merged commit 14ee345 into feature/razor-parser Sep 26, 2018
@ajaybhargavb ajaybhargavb deleted the ajbaaska/htmltocodeswitch branch September 26, 2018 18:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants