This repository was archived by the owner on Dec 18, 2018. It is now read-only.
Bring in BuffersExtensions WriteMultiSegment#1918
Closed
benaadams wants to merge 7 commits into
Closed
Conversation
Member
|
When I tired this, nothing got faster. |
Contributor
Author
Spoliers... am still running benchmarks |
Contributor
Author
|
Yeah no real change, wonder about skipping GetSpan
|
benaadams
force-pushed
the
WriteMultiSegment
branch
from
aec44eb to
b1c7bdc
Compare
Contributor
Author
|
Still not a great difference :( |
benaadams
force-pushed
the
WriteMultiSegment
branch
2 times, most recently
from
d0bfd5c to
6b16de6
Compare
JamesNK
reviewed
Apr 9, 2018
| var packer = Packer.Create(output, PackerCompatibilityOptions.None); | ||
| switch (message) | ||
|
|
||
| if (message is InvocationMessage invocationMessage) |
Contributor
Author
There was a problem hiding this comment.
"Pattern matching switch generates junkier code than if" f9ce436
; Total bytes of code 657, prolog size 10 for method
MessagePackHubProtocol:WriteMessageCore(ref,ref):this
vs
; Total bytes of code 612, prolog size 10 for method
MessagePackHubProtocol:WriteMessageCore(ref,ref):this
Still seems noisy though
Contributor
Author
There was a problem hiding this comment.
They both generate junky code; I think so the stack trace unwinds through the correct point :-/
benaadams
force-pushed
the
WriteMultiSegment
branch
from
6b16de6 to
e784a5e
Compare
; Total bytes of code 657, prolog size 10 for method MessagePackHubProtocol:WriteMessageCore(ref,ref):this vs ; Total bytes of code 612, prolog size 10 for method MessagePackHubProtocol:WriteMessageCore(ref,ref):this Still seems noisy though
; Total bytes of code 195, prolog size 11 for method MemoryBufferWriter:Reset():this vs ; Total bytes of code 181, prolog size 8 for method MemoryBufferWriter:Reset():this
Contributor
Author
|
asm is better; but the benchmarks are saying its underwhelming :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.