Release 0.59.2-0.4.2 - massive refactoring, new RC base version, all new and almost shiny#98
Merged
Release 0.59.2-0.4.2 - massive refactoring, new RC base version, all new and almost shiny#98
Conversation
[FIX] Removing pipe and commas from custom emojis (RocketChat#8168)
[FIX] [i18n] My Profile & README.md links
…s-alignment [FIX] Attachment icons alignment in LTR and RTL
…tton [FIX] "Cancel button" on modal in RTL in Firefox 55
"Username_Placeholder": "Please enter usernames...", "Channel_Name_Placeholder": "Please enter channel name...", "New_Password_Placeholder": "Please enter new password...", "Name_Placeholder": "Please enter your name...", "Email_Placeholder": "Please enter your email address...",
…translatoins [FIX] Missing placeholder translations
fix color on unread messages
[FIX] Emoji Picker hidden for reactions in RTL
[FIX] Call buttons with wrong margin on RTL
[FIX] Amin menu not showing all items & File list breaking line
…ned-attachments [FIX] Check attachments is defined before accessing first element
…n-room-notification [FIX] TypeError: Cannot read property 't' of undefined
…-file-name [FIX] Wrong file name when upload to AWS S3
…m.js should be properly resolved
mrsimpson
changed the title
Member
Author
|
@janrudolph merged the latest fix version of RC. This should have fixed the guest pool. Can you please test and confirm? |
quick hack for IE
…ocket.Chat into release/0.59.2-0.4.2
|
The following things were tested successfully:
The following tests have failed:
|
Member
Author
|
@janrudolph the issues found shall be fixed. Couldn't test the Smarti scrolling due to missing test-data / connectivity. If that's fine, please accept the review |
Member
Author
|
I didn't get the scrollbar hidden properly ;( Now, once again two hierarchical scrollbars are there. Let's leave it for now, this is not crucial. |
ghost
removed
the
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR contains the basis of Assistify Rocket.Chat the way it should have been from the beginning: Loose coupling towards RC, less legacy artifacts, better quality (though still far from perfect).
In order to do that, RC needed to be updated to the most recent version.
Diff towards
developSinve the changelist is huge, the following list describes what's been done in order to achive the current state
Call to action
Due to the massive changelist, I ask all fellow developers to
@janrudolph I'll publish this release-candiadate to our team-server soon and ask you for functional testing.