This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Improve staging view selection UX #300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 23 commits
October 19, 2016 13:36
This will be used to model the selection state of the staging view. Signed-off-by: Katrina Uychaco <kuychaco@github.com>
Signed-off-by: Katrina Uychaco <kuychaco@github.com>
...if the old head item is removed from the list.
Delete some that have been subsumed by unit tests on the selection.
We need to rework this whole code path, but this prevents issues in the meantime.
Contributor
Author
|
Looks like there's just one Travis failure holding this back. |
nathansobo
force-pushed
the
ns-staging-selection
branch
from
648280c to
baa30d0
Compare
added 2 commits
October 28, 2016 22:49
This works around a weird sequence of events in tests where a file patch view can become activated for a repository right before it is destroyed.
Contributor
Author
|
Gonna merge because this is a pretty clear improvement and we don't need to treat |
Contributor
|
Nice! ⚡️⚡️⚡️ |
This was referenced Jan 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the selection UX of the staging view consistent with the file patch view. It adds the following features:
Closes #271
Closes #260 (we've decided to continue to update the diff and revisit this UX later)
Closes #210
Closes #192
/cc @kuychaco