Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

replace Handle with Local#127

Merged
rafeca merged 1 commit intoatom:masterfrom
typora:master
Jun 12, 2019
Merged

replace Handle with Local#127
rafeca merged 1 commit intoatom:masterfrom
typora:master

Conversation

@abnerlee
Copy link
Copy Markdown
Contributor

@abnerlee abnerlee commented Apr 26, 2019

see https://electronjs.org/blog/nodejs-native-addons-and-electron-5

Electron 5.0 includes a version of V8 that has finally removed v8::Handle for good, and native Node.js addons that still use it will need to be updated before they can be used with Electron 5.0.

@benjamn
Copy link
Copy Markdown
Contributor

benjamn commented Apr 30, 2019 •
edited
Loading

The update to V8 7.4 makes this change necessary for Node.js 12 compatibility, too.

benjamn added a commit to meteor/node-pathwatcher that referenced this pull request May 6, 2019
@benjamn
Fix all compilation errors and warnings for Node.js 12 (V8 7.4).
3623544 
Depends on s/Handle/Local/ work started by @abnerlee in
atom#127.
@benjamn benjamn mentioned this pull request May 6, 2019
Merged
rafeca
rafeca approved these changes Jun 12, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@rafeca rafeca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@rafeca rafeca merged commit e9d54f5 into atom:master Jun 12, 2019
@rafeca rafeca self-assigned this Jun 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@rafeca rafeca rafeca approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rafeca rafeca

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@abnerlee @benjamn @rafeca @rsese