Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/common.cc
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ static void MakeCallbackInMainThread(uv_async_t* handle, int status) {
Nan::HandleScope scope;

if (!g_callback.IsEmpty()) {
Handle<String> type;
Local<String> type;
switch (g_type) {
case EVENT_CHANGE:
type = Nan::New("change").ToLocalChecked();
Expand Down Expand Up @@ -52,7 +52,7 @@ static void MakeCallbackInMainThread(uv_async_t* handle, int status) {
return;
}

Handle<Value> argv[] = {
Local<Value> argv[] = {
type,
WatcherHandleToV8Value(g_handle),
Nan::New(g_new_path.data(), g_new_path.size()).ToLocalChecked(),
Expand Down Expand Up @@ -121,7 +121,7 @@ NAN_METHOD(Watch) {
if (!info[0]->IsString())
return Nan::ThrowTypeError("String required");

Handle<String> path = info[0]->ToString();
Local<String> path = info[0]->ToString();
WatcherHandle handle = PlatformWatch(*String::Utf8Value(path));
if (!PlatformIsHandleValid(handle)) {
int error_number = PlatformInvalidHandleToErrorNumber(handle);
Expand Down Expand Up @@ -154,7 +154,7 @@ NAN_METHOD(Unwatch) {
Nan::HandleScope scope;

if (!IsV8ValueWatcherHandle(info[0]))
return Nan::ThrowTypeError("Handle type required");
return Nan::ThrowTypeError("Local type required");

PlatformUnwatch(V8ValueToWatcherHandle(info[0]));

Expand Down
2 changes: 1 addition & 1 deletion src/handle_map.cc
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ NAN_METHOD(HandleMap::Clear) {
}

// static
void HandleMap::Initialize(Handle<Object> target) {
void HandleMap::Initialize(Local<Object> target) {
Nan::HandleScope scope;

Local<FunctionTemplate> t = Nan::New<FunctionTemplate>(HandleMap::New);
Expand Down
2 changes: 1 addition & 1 deletion src/handle_map.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

class HandleMap : public Nan::ObjectWrap {
public:
static void Initialize(Handle<Object> target);
static void Initialize(Local<Object> target);

private:
typedef std::map<WatcherHandle, NanUnsafePersistent<Value> > Map;
Expand Down
2 changes: 1 addition & 1 deletion src/main.cc
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

namespace {

void Init(Handle<Object> exports) {
void Init(Local<Object> exports) {
CommonInit();
PlatformInit();

Expand Down
4 changes: 2 additions & 2 deletions src/unsafe_persistent.h
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ class NanUnsafePersistent : public NanUnsafePersistentTraits<T>::HandleType {
template<typename T>
NAN_INLINE void NanAssignUnsafePersistent(
NanUnsafePersistent<T>& handle
, v8::Handle<T> obj) {
, v8::Local<T> obj) {
handle.Reset();
handle = NanUnsafePersistent<T>(v8::Isolate::GetCurrent(), obj);
}
Expand All @@ -43,7 +43,7 @@ NAN_INLINE v8::Local<T> NanUnsafePersistentToLocal(const NanUnsafePersistent<T>
template<typename T>
NAN_INLINE void NanAssignUnsafePersistent(
v8::Persistent<T>& handle
, v8::Handle<T> obj) {
, v8::Local<T> obj) {
handle.Dispose();
handle = v8::Persistent<T>::New(obj);
}
Expand Down