Conversation
| @@ -0,0 +1,111 @@ | |||
| class UserIdentity { | |||
There was a problem hiding this comment.
We already have a User_Profile class defined . Please re use that
| }); | ||
|
|
||
| Future<bool> storeCredentials(final Credentials credentials); | ||
| Future<UserInfo> getIDTokenContents(); |
There was a problem hiding this comment.
Shouldn't this be of nullable type ,in the scneario if the credentials aren't available and someone invokes this api ?
| } | ||
|
|
||
| /// Retrieves the credentials from the native storage. | ||
| Future<UserInfo> getIDTokenContents(final CredentialsManagerRequest request) { |
There was a problem hiding this comment.
The Credentials class uses a user property for this. Since this method here is exposing exactly the same functionality (parsing and returning the info contained in the ID token), we should stick to the same naming convention, otherwise it could be confusing. Using different names for the same thing may suggest these are actually different things, or that there is a substantive difference.
| @@ -0,0 +1,16 @@ | |||
|
|
|||
There was a problem hiding this comment.
There are a couple of symlinks missing. See https://github.com/auth0/auth0-flutter/actions/runs/15893748250/job/44821016570?pr=607
Widcket
left a comment
There was a problem hiding this comment.
Please also add Dart tests and Swift tests.
- Dart: https://github.com/auth0/auth0-flutter/blob/main/auth0_flutter_platform_interface/test/method_channel_credentials_manager_test.dart and https://github.com/auth0/auth0-flutter/blob/main/auth0_flutter/test/mobile/credentials_manager_test.dart
- Swift: https://github.com/auth0/auth0-flutter/blob/main/auth0_flutter/example/ios/Tests/CredentialsManager/CredentialsManagerHandlerTests.swift#L259-L262 and https://github.com/auth0/auth0-flutter/tree/main/auth0_flutter/example/ios/Tests/CredentialsManager (the new handler needs its own test file)
There was a problem hiding this comment.
@NandanPrabhu Let’s resolve the open comments, then we can test and merge this to close the GH issue
…/actions/setup-darwin (#709) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…/actions/setup-darwin (#710) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…/actions/setup-darwin (#713) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…/actions/setup-darwin (#716) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…/actions/setup-darwin (#719) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [ruby/setup-ruby](https://github.com/ruby/setup-ruby) from 1.281.0 to 1.282.0. - [Release notes](https://github.com/ruby/setup-ruby/releases) - [Changelog](https://github.com/ruby/setup-ruby/blob/master/release.rb) - [Commits](ruby/setup-ruby@675dd7b...4fc31e1) --- updated-dependencies: - dependency-name: ruby/setup-ruby dependency-version: 1.282.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…/actions/setup-darwin (#722) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…/actions/setup-darwin (#725) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
|
||
|
|
||
| class GetCredentialsUserInfoRequestHandler: CredentialsManagerRequestHandler { | ||
| override val method: String = "credentialsManager#user" |
There was a problem hiding this comment.
should we update the example doc please ignore if already done
There was a problem hiding this comment.
Have updated the Examples.md file
|
PR looks good. but just wanted to confirm if user property when converting between native dictionary to dart dictionary we are able to get all the values correctly @pmathew92 |
|
@NandanPrabhu Yes, I tried some properties and I was able to fetch them like |
@pmathew92 this is for both the platforms right? |
|
* main: (22 commits) build(deps): bump ruby/setup-ruby from 1.286.0 to 1.288.0 in /.github/actions/setup-darwin (#740) CredentialsManager user info/ID token contents accessible via flutter SDK (#607) CI cleanup Avoid running always failing smoke tests for iOS make PR runs with release workflow that triggers flutter analyze udpate pubspec udpate podspecs Release af-v2.0.0-beta.2 pubspec update for beta release Release afpi-v2.0.0-beta.2 fix flutter analyse errors build(deps): bump ruby/setup-ruby from 1.285.0 to 1.286.0 in /.github/actions/setup-darwin (#728) build(deps-dev): bump lodash from 4.17.21 to 4.17.23 in /appium-test (#729) chore:Fixed errors from flutter analyze (#727) feat: Add allowedBrowsers parameter to logout API [SDK-724] (#726) build(deps): bump ruby/setup-ruby from 1.283.0 to 1.285.0 in /.github/actions/setup-darwin (#725) address feedback refactor fix test cases and code refactoring fixed test cases ...
* main: (79 commits) build(deps): bump aws-actions/configure-aws-credentials from 5.1.1 to 6.0.0 in /.github/actions/rl-scanner (#744) chore: updated the RL wrapper installation path (#746) Release af-v2.0.0-beta.3 (#743) Release afpi-v2.0.0-beta.3 (#742) Release afpi-v2.0.0-beta.3 (#741) build(deps): bump ruby/setup-ruby from 1.286.0 to 1.288.0 in /.github/actions/setup-darwin (#740) CredentialsManager user info/ID token contents accessible via flutter SDK (#607) CI cleanup Avoid running always failing smoke tests for iOS make PR runs with release workflow that triggers flutter analyze udpate pubspec udpate podspecs Release af-v2.0.0-beta.2 pubspec update for beta release Release afpi-v2.0.0-beta.2 fix flutter analyse errors build(deps): bump ruby/setup-ruby from 1.285.0 to 1.286.0 in /.github/actions/setup-darwin (#728) build(deps-dev): bump lodash from 4.17.21 to 4.17.23 in /appium-test (#729) chore:Fixed errors from flutter analyze (#727) feat: Add allowedBrowsers parameter to logout API [SDK-724] (#726) ...
📋 Changes
This PR exposes api to access ID Token contents via Credentials Manager in flutter SDK
GH issue #378 will be addressed via this PR
📎 References
🎯 Testing