Skip to content

Comments

chore:Fixed errors from flutter analyze#727

Merged
pmathew92 merged 1 commit intomainfrom
chore/analyze_error
Jan 21, 2026
Merged

chore:Fixed errors from flutter analyze#727
pmathew92 merged 1 commit intomainfrom
chore/analyze_error

Conversation

@pmathew92
Copy link
Contributor

📋 Changes

This PR fixes error returned by the flutter analyze command

@pmathew92 pmathew92 merged commit b1aabb2 into main Jan 21, 2026
15 of 17 checks passed
@pmathew92 pmathew92 deleted the chore/analyze_error branch January 21, 2026 12:39
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses errors reported by the flutter analyze command by reformatting documentation comments and code to comply with line length restrictions.

Changes:

  • Fixed documentation line wrapping in multiple files to meet line length requirements
  • Reformatted code statements across test and implementation files to fit within analyzer limits

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
auth0_flutter_platform_interface/lib/src/web/exchange_token_options.dart Wrapped long documentation comments for audience and organizationId parameters
auth0_flutter_platform_interface/lib/src/auth0_flutter_web_platform.dart Reformatted UnimplementedError to span multiple lines
auth0_flutter/test/web/auth0_flutter_web_test.dart Split createJsException call arguments across multiple lines
auth0_flutter/test/mobile/web_authentication_test.dart Wrapped expect statement to fit line length requirements
auth0_flutter/lib/src/mobile/authentication_api.dart Reformatted documentation comments and removed trailing spaces
auth0_flutter/lib/auth0_flutter_web.dart Wrapped long documentation lines for better readability

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

when(mockClientProxy.exchangeToken(any))
.thenThrow(createJsException(errorCase['code']!, errorCase['message']!));
.thenThrow(createJsException(errorCase['code']!,
errorCase['message']!));
Copy link

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The closing parenthesis on line 501 is not properly indented. It should align with the opening of the createJsException call on line 500, consistent with Dart formatting conventions.

Suggested change
errorCase['message']!));
errorCase['message']!));

Copilot uses AI. Check for mistakes.
///
/// * [subjectToken] is the token obtained from the external identity provider.
/// * [subjectTokenType] specifies the format of the subject token (e.g.,
/// * [subjectToken] the token obtained from the external identity provider.
Copy link

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation for subjectToken is inconsistent with other parameter descriptions in this file. Other parameters use "- The" or similar prefix (e.g., "- The API identifier", "- Optional API identifier"), but this line uses just "the token". Consider changing to "- The token obtained from the external identity provider" for consistency.

Suggested change
/// * [subjectToken] the token obtained from the external identity provider.
/// * [subjectToken] The token obtained from the external identity provider.

Copilot uses AI. Check for mistakes.
@@ -7,9 +7,11 @@
///
/// * [subjectToken] - The external token to be exchanged (required)
/// * [subjectTokenType] - A URI that indicates the type of the subject token,
Copy link

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation for the subjectTokenType parameter is incomplete. Line 9 ends with a comma but doesn't provide a description of what this parameter represents, unlike the other parameters which have complete descriptions.

Suggested change
/// * [subjectTokenType] - A URI that indicates the type of the subject token,
/// * [subjectTokenType] - A URI that indicates the type of the subject token (required)

Copilot uses AI. Check for mistakes.
Comment on lines +44 to +46
throw UnimplementedError(
'web.customTokenExchange has not been implemented'
);
Copy link

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The closing parenthesis and semicolon for the UnimplementedError should be on the same line as the string message, consistent with the formatting of other UnimplementedError calls in the same file (see lines 21, 28, 32, 36, 40, and 56). The current formatting places them on a separate line without proper indentation.

Suggested change
throw UnimplementedError(
'web.customTokenExchange has not been implemented'
);
throw UnimplementedError('web.customTokenExchange has not been implemented');

Copilot uses AI. Check for mistakes.
NandanPrabhu added a commit that referenced this pull request Jan 26, 2026
* main:
  udpate pubspec
  udpate podspecs
  Release af-v2.0.0-beta.2
  pubspec update for beta release
  Release afpi-v2.0.0-beta.2
  fix flutter analyse errors
  build(deps): bump ruby/setup-ruby from 1.285.0 to 1.286.0 in /.github/actions/setup-darwin (#728)
  build(deps-dev): bump lodash from 4.17.21 to 4.17.23 in /appium-test (#729)
  chore:Fixed errors from flutter analyze (#727)
  feat: Add allowedBrowsers parameter to logout API [SDK-724] (#726)
  build(deps): bump ruby/setup-ruby from 1.283.0 to 1.285.0 in /.github/actions/setup-darwin (#725)
  address feedback
  refactor
  fix test cases and code refactoring
  fixed test cases
  fixed test cases
  feat: add custom token exchange support across all platforms
pmathew92 added a commit that referenced this pull request Feb 2, 2026
NandanPrabhu added a commit that referenced this pull request Feb 4, 2026
* main: (22 commits)
  build(deps): bump ruby/setup-ruby from 1.286.0 to 1.288.0 in /.github/actions/setup-darwin (#740)
  CredentialsManager user info/ID token contents accessible via flutter SDK (#607)
  CI cleanup
  Avoid running always failing smoke tests for iOS
  make PR runs  with release workflow that triggers flutter analyze
  udpate pubspec
  udpate podspecs
  Release af-v2.0.0-beta.2
  pubspec update for beta release
  Release afpi-v2.0.0-beta.2
  fix flutter analyse errors
  build(deps): bump ruby/setup-ruby from 1.285.0 to 1.286.0 in /.github/actions/setup-darwin (#728)
  build(deps-dev): bump lodash from 4.17.21 to 4.17.23 in /appium-test (#729)
  chore:Fixed errors from flutter analyze (#727)
  feat: Add allowedBrowsers parameter to logout API [SDK-724] (#726)
  build(deps): bump ruby/setup-ruby from 1.283.0 to 1.285.0 in /.github/actions/setup-darwin (#725)
  address feedback
  refactor
  fix test cases and code refactoring
  fixed test cases
  ...
NandanPrabhu added a commit that referenced this pull request Feb 23, 2026
* main: (79 commits)
  build(deps): bump aws-actions/configure-aws-credentials from 5.1.1 to 6.0.0 in /.github/actions/rl-scanner (#744)
  chore:  updated the RL wrapper installation path (#746)
  Release af-v2.0.0-beta.3 (#743)
  Release afpi-v2.0.0-beta.3 (#742)
  Release afpi-v2.0.0-beta.3 (#741)
  build(deps): bump ruby/setup-ruby from 1.286.0 to 1.288.0 in /.github/actions/setup-darwin (#740)
  CredentialsManager user info/ID token contents accessible via flutter SDK (#607)
  CI cleanup
  Avoid running always failing smoke tests for iOS
  make PR runs  with release workflow that triggers flutter analyze
  udpate pubspec
  udpate podspecs
  Release af-v2.0.0-beta.2
  pubspec update for beta release
  Release afpi-v2.0.0-beta.2
  fix flutter analyse errors
  build(deps): bump ruby/setup-ruby from 1.285.0 to 1.286.0 in /.github/actions/setup-darwin (#728)
  build(deps-dev): bump lodash from 4.17.21 to 4.17.23 in /appium-test (#729)
  chore:Fixed errors from flutter analyze (#727)
  feat: Add allowedBrowsers parameter to logout API [SDK-724] (#726)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants