Fixed Nginx and updated Consul image #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misterbisson
force-pushed
the
nginx-coprocess
branch
from
e4e3839 to
f2f1968
Compare
|
LGTM except for my concerns in autopilotpattern/nginx#18 (comment) |
misterbisson
force-pushed
the
nginx-coprocess
branch
from
473e4ab to
bed131c
Compare
| command: > | ||
| /usr/local/bin/containerpilot | ||
| /bin/consul agent -server | ||
| -bootstrap-expect 1 |
Contributor
Author
There was a problem hiding this comment.
@tgross this works to create a one-node Consul cluster that we can then scale to N nodes via Docker Compose.
There was a problem hiding this comment.
I don't think that works -- when a node comes up if it expects only 1 and the CNS name it resolves is itself, then it'll form a split brain cluter.
Contributor
Author
There was a problem hiding this comment.
Crap, you're right about that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If merged, it should be tagged as
4.5.3-r2.